From 280f5069459549a67abc1aaf60a7f674da469f60 Mon Sep 17 00:00:00 2001 From: Piet Wolff Date: Mon, 13 May 2024 14:36:43 +0200 Subject: [PATCH 1/7] init eval --- evaluations/tokenguard_m1_piewol.md | 32 +++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 evaluations/tokenguard_m1_piewol.md diff --git a/evaluations/tokenguard_m1_piewol.md b/evaluations/tokenguard_m1_piewol.md new file mode 100644 index 000000000..08eeaf7a3 --- /dev/null +++ b/evaluations/tokenguard_m1_piewol.md @@ -0,0 +1,32 @@ +# Evaluation + +- **Status:** in progress +- **Application Document:** https://github.com/w3f/Grants-Program/blob/master/applications/Tokenguard.md +- **Milestone:** 1 +- **Previously successfully merged evaluation:** All evaluations by PieWol + +**Milestone Number:** 1 + +**Deliverables** + +| Number | Deliverable | Accepted | Link | Evaluation Notes | +| ------ | ----------- | -------- | ---- |----------------- | +| 0a | License || https://github.com/tokenguardio/dashboard-creator-client/blob/dev/LICENSE | ok | +| 0b | Documentation || https://github.com/tokenguardio/dashboard-creator-client/blob/dev/README.md | please extend the readme. see notes.| +| 0c | Testing and Testing Guide ||https://github.com/tokenguardio/dashboard-creator-client/tree/dev/src/tests| There is no explicit testing guide. Unit tests are passing.| +| 0d | Dockerfile || https://github.com/tokenguardio/dashboard-creator-client/blob/dev/Dockerfile | Why is this not mentioned in the readme? | +| 1 | Metrics Visualization || https://github.com/tokenguardio/dashboard-creator-client | please fix the link. | +| 2 | Dashboard Layout || https://github.com/tokenguardio/dashboard-creator-client | please fix the link. | +| 3 | Metric Catalogue || https://github.com/tokenguardio/dashboard-creator-client | Please fix the link to point at the actual deliverable. E.g. a directory of your repo with the relevant code. Or a relevant section of the documentation.| + + +## General notes +The dockerfile is completely unmentioned in the readme. Please include a guide to use your project with docker in your readme. Why is almost always the repo root link given for the deliverables? Please use a link as specific to the deliverables as possible. + +Please provide an explicit testing guide that gives a tutorial on how to test both the frontend and backend together as this seems to be necessary to save dashboards aswell as even creating visualizations. This testing guide should focus on how to setup backend and frontend locally. + +# Visuals +the "delete" and "edit" button from the button settings are overshadowed by the arrow to resize the button itself. In certain sizes of the button these overlap which seems annoying. It would be good if the settings for the button would be on top of the resizing arrow. + +# UX +Whenever I am in the settings and have modified anything, I want to go back to designing my dashboard. Yet when I click back into the dashboard to the right of the settings, the settings are not closing. I would expect to see the settings being closed in this case. Same holds true for clicking the "plus" button for adding another element to the dashboard. From 3af43228d4813747a568703d4539a40eb0b65c8f Mon Sep 17 00:00:00 2001 From: Piet Wolff Date: Sun, 26 May 2024 22:45:58 +0200 Subject: [PATCH 2/7] update links --- evaluations/tokenguard_m1_piewol.md | 22 +++++++--------------- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/evaluations/tokenguard_m1_piewol.md b/evaluations/tokenguard_m1_piewol.md index 08eeaf7a3..47b78a2ad 100644 --- a/evaluations/tokenguard_m1_piewol.md +++ b/evaluations/tokenguard_m1_piewol.md @@ -11,22 +11,14 @@ | Number | Deliverable | Accepted | Link | Evaluation Notes | | ------ | ----------- | -------- | ---- |----------------- | -| 0a | License || https://github.com/tokenguardio/dashboard-creator-client/blob/dev/LICENSE | ok | -| 0b | Documentation || https://github.com/tokenguardio/dashboard-creator-client/blob/dev/README.md | please extend the readme. see notes.| -| 0c | Testing and Testing Guide ||https://github.com/tokenguardio/dashboard-creator-client/tree/dev/src/tests| There is no explicit testing guide. Unit tests are passing.| -| 0d | Dockerfile || https://github.com/tokenguardio/dashboard-creator-client/blob/dev/Dockerfile | Why is this not mentioned in the readme? | -| 1 | Metrics Visualization || https://github.com/tokenguardio/dashboard-creator-client | please fix the link. | -| 2 | Dashboard Layout || https://github.com/tokenguardio/dashboard-creator-client | please fix the link. | -| 3 | Metric Catalogue || https://github.com/tokenguardio/dashboard-creator-client | Please fix the link to point at the actual deliverable. E.g. a directory of your repo with the relevant code. Or a relevant section of the documentation.| +| 0a | License || https://github.com/tokenguardio/dashboard-creator-client/blob/v2.0.3/LICENSE | ok | +| 0b | Documentation || https://github.com/tokenguardio/dashboard-creator-client/blob/v2.0.3/README.md | | +| 0c | Testing and Testing Guide ||https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.3/TESTING| great testing guide | +| 0d | Dockerfile || https://github.com/tokenguardio/dashboard-creator-client/blob/v2.0.3/Dockerfile | | +| 1 | Metrics Visualization || https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.3/ | | +| 2 | Dashboard Layout || https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.3/ | | +| 3 | Metric Catalogue || https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.3/ | | ## General notes -The dockerfile is completely unmentioned in the readme. Please include a guide to use your project with docker in your readme. Why is almost always the repo root link given for the deliverables? Please use a link as specific to the deliverables as possible. -Please provide an explicit testing guide that gives a tutorial on how to test both the frontend and backend together as this seems to be necessary to save dashboards aswell as even creating visualizations. This testing guide should focus on how to setup backend and frontend locally. - -# Visuals -the "delete" and "edit" button from the button settings are overshadowed by the arrow to resize the button itself. In certain sizes of the button these overlap which seems annoying. It would be good if the settings for the button would be on top of the resizing arrow. - -# UX -Whenever I am in the settings and have modified anything, I want to go back to designing my dashboard. Yet when I click back into the dashboard to the right of the settings, the settings are not closing. I would expect to see the settings being closed in this case. Same holds true for clicking the "plus" button for adding another element to the dashboard. From 0387105c9d19af965b2e883c76749aea2b6b4a78 Mon Sep 17 00:00:00 2001 From: Piet Wolff Date: Mon, 27 May 2024 16:57:26 +0200 Subject: [PATCH 3/7] accept m1 --- evaluations/tokenguard_1_piewol.md | 35 +++++++++++++++++++++++++++++ evaluations/tokenguard_m1_piewol.md | 24 -------------------- 2 files changed, 35 insertions(+), 24 deletions(-) create mode 100644 evaluations/tokenguard_1_piewol.md delete mode 100644 evaluations/tokenguard_m1_piewol.md diff --git a/evaluations/tokenguard_1_piewol.md b/evaluations/tokenguard_1_piewol.md new file mode 100644 index 000000000..406446515 --- /dev/null +++ b/evaluations/tokenguard_1_piewol.md @@ -0,0 +1,35 @@ +# Evaluation + +- **Status:** accepted +- **Application Document:** https://github.com/w3f/Grants-Program/blob/master/applications/Tokenguard.md +- **Milestone:** 1 +- **Previously successfully merged evaluation:** All evaluations by PieWol + +**Milestone Number:** 1 + +**Deliverables** + +| Number | Deliverable | Accepted | Link | Evaluation Notes | +| ------ | ----------- | -------- | ---- |----------------- | +| 0a | License |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/blob/v2.0.3/LICENSE | ok | +| 0b | Documentation |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/blob/v2.0.3/README.md |good| +| 0c | Testing and Testing Guide |
  • [x]
|https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.3/TESTING| great testing guide | +| 0d | Dockerfile |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/blob/v2.0.3/Dockerfile | works | +| 1 | Metrics Visualization |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.3/ | | +| 2 | Dashboard Layout |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.3/ | | +| 3 | Metric Catalogue |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.3/ | thanks for making this testable | + + +## General notes +Thanks for improving the testing guide. + +## Unit Tests +All passing + +``` +Test Suites: 6 passed, 6 total +Tests: 20 passed, 20 total +Snapshots: 0 total +Time: 4.273 s +``` + diff --git a/evaluations/tokenguard_m1_piewol.md b/evaluations/tokenguard_m1_piewol.md deleted file mode 100644 index 47b78a2ad..000000000 --- a/evaluations/tokenguard_m1_piewol.md +++ /dev/null @@ -1,24 +0,0 @@ -# Evaluation - -- **Status:** in progress -- **Application Document:** https://github.com/w3f/Grants-Program/blob/master/applications/Tokenguard.md -- **Milestone:** 1 -- **Previously successfully merged evaluation:** All evaluations by PieWol - -**Milestone Number:** 1 - -**Deliverables** - -| Number | Deliverable | Accepted | Link | Evaluation Notes | -| ------ | ----------- | -------- | ---- |----------------- | -| 0a | License |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/blob/v2.0.3/LICENSE | ok | -| 0b | Documentation |
  • [ ]
| https://github.com/tokenguardio/dashboard-creator-client/blob/v2.0.3/README.md | | -| 0c | Testing and Testing Guide |
  • [ ]
|https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.3/TESTING| great testing guide | -| 0d | Dockerfile |
  • [ ]
| https://github.com/tokenguardio/dashboard-creator-client/blob/v2.0.3/Dockerfile | | -| 1 | Metrics Visualization |
  • [ ]
| https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.3/ | | -| 2 | Dashboard Layout |
  • [ ]
| https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.3/ | | -| 3 | Metric Catalogue |
  • [ ]
| https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.3/ | | - - -## General notes - From efb48ce75bbcdfac0f2514fb8a4aeb452b1e3c16 Mon Sep 17 00:00:00 2001 From: Piet Wolff Date: Mon, 27 May 2024 17:10:52 +0200 Subject: [PATCH 4/7] piechart missing? --- evaluations/tokenguard_1_piewol.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/evaluations/tokenguard_1_piewol.md b/evaluations/tokenguard_1_piewol.md index 406446515..d5115207b 100644 --- a/evaluations/tokenguard_1_piewol.md +++ b/evaluations/tokenguard_1_piewol.md @@ -15,7 +15,7 @@ | 0b | Documentation |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/blob/v2.0.3/README.md |good| | 0c | Testing and Testing Guide |
  • [x]
|https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.3/TESTING| great testing guide | | 0d | Dockerfile |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/blob/v2.0.3/Dockerfile | works | -| 1 | Metrics Visualization |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.3/ | | +| 1 | Metrics Visualization |
  • []
| https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.3/ | Looks like there is only bar and linechart available. How can I configure a pie chart? | | 2 | Dashboard Layout |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.3/ | | | 3 | Metric Catalogue |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.3/ | thanks for making this testable | From de49beeced647460d91458fa33099ca6ffa13f12 Mon Sep 17 00:00:00 2001 From: Piet Wolff Date: Mon, 27 May 2024 17:11:10 +0200 Subject: [PATCH 5/7] update --- evaluations/tokenguard_1_piewol.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/evaluations/tokenguard_1_piewol.md b/evaluations/tokenguard_1_piewol.md index d5115207b..a08479a66 100644 --- a/evaluations/tokenguard_1_piewol.md +++ b/evaluations/tokenguard_1_piewol.md @@ -1,6 +1,6 @@ # Evaluation -- **Status:** accepted +- **Status:** in progress - **Application Document:** https://github.com/w3f/Grants-Program/blob/master/applications/Tokenguard.md - **Milestone:** 1 - **Previously successfully merged evaluation:** All evaluations by PieWol From 244cbd65449c8e5b8dca98c3e2145292079dda5a Mon Sep 17 00:00:00 2001 From: Piet Wolff Date: Thu, 30 May 2024 21:50:32 +0200 Subject: [PATCH 6/7] accept --- evaluations/tokenguard_1_piewol.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/evaluations/tokenguard_1_piewol.md b/evaluations/tokenguard_1_piewol.md index a08479a66..7d2e67150 100644 --- a/evaluations/tokenguard_1_piewol.md +++ b/evaluations/tokenguard_1_piewol.md @@ -1,6 +1,6 @@ # Evaluation -- **Status:** in progress +- **Status:** accepted - **Application Document:** https://github.com/w3f/Grants-Program/blob/master/applications/Tokenguard.md - **Milestone:** 1 - **Previously successfully merged evaluation:** All evaluations by PieWol @@ -11,13 +11,13 @@ | Number | Deliverable | Accepted | Link | Evaluation Notes | | ------ | ----------- | -------- | ---- |----------------- | -| 0a | License |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/blob/v2.0.3/LICENSE | ok | -| 0b | Documentation |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/blob/v2.0.3/README.md |good| -| 0c | Testing and Testing Guide |
  • [x]
|https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.3/TESTING| great testing guide | -| 0d | Dockerfile |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/blob/v2.0.3/Dockerfile | works | -| 1 | Metrics Visualization |
  • []
| https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.3/ | Looks like there is only bar and linechart available. How can I configure a pie chart? | -| 2 | Dashboard Layout |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.3/ | | -| 3 | Metric Catalogue |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.3/ | thanks for making this testable | +| 0a | License |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/blob/v2.0.4/LICENSE | ok | +| 0b | Documentation |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/blob/v2.0.4/README.md |good| +| 0c | Testing and Testing Guide |
  • [x]
|https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.4/TESTING| great testing guide | +| 0d | Dockerfile |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/blob/v2.0.4/Dockerfile | works | +| 1 | Metrics Visualization |
  • []
| https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.4/ | all visualization types work | +| 2 | Dashboard Layout |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.4/ | ok | +| 3 | Metric Catalogue |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.4/ | thanks for making this testable | ## General notes From 2bfea90c63d1809a8d7d1b9e9340768c7888ffa6 Mon Sep 17 00:00:00 2001 From: Piet Wolff Date: Thu, 30 May 2024 21:51:05 +0200 Subject: [PATCH 7/7] add approval --- evaluations/tokenguard_1_piewol.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/evaluations/tokenguard_1_piewol.md b/evaluations/tokenguard_1_piewol.md index 7d2e67150..0bcf4edac 100644 --- a/evaluations/tokenguard_1_piewol.md +++ b/evaluations/tokenguard_1_piewol.md @@ -15,7 +15,7 @@ | 0b | Documentation |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/blob/v2.0.4/README.md |good| | 0c | Testing and Testing Guide |
  • [x]
|https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.4/TESTING| great testing guide | | 0d | Dockerfile |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/blob/v2.0.4/Dockerfile | works | -| 1 | Metrics Visualization |
  • []
| https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.4/ | all visualization types work | +| 1 | Metrics Visualization |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.4/ | all visualization types work | | 2 | Dashboard Layout |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.4/ | ok | | 3 | Metric Catalogue |
  • [x]
| https://github.com/tokenguardio/dashboard-creator-client/tree/v2.0.4/ | thanks for making this testable |