TCDT Milestone 2

[khalidzahra]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• This pull request is being made by the same account as the accepted application.
• I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
• In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: Private application. Project name: tcdt

[semuelle]

Hi @khalidzahra, the tcdt-milestone-1.md file is already merged (#1241). Can you remove it from this PR?

Also, sorry for the delay. @PieWol is currently out, but will soon return to evaluating.

[khalidzahra]

Hey @semuelle, no worries! I removed the tcdt-milestone-1.md file as you requested :)

[PieWol]

Hey @khalidzahra ,
sorry for the delay. I was out last week. Could you please adjust the links for the protocol deliverables so that they point to the relevant code? I'd argue that would be more expressive than the images within the readme. What do you think?

[PieWol]

For the testing guide deliverable it would be nice if you could create an easy to follow step by step guide that demonstrates what was achieved in this milestone.

[khalidzahra]

Hey @PieWol, thank you for your valuable feedback and sorry for the delayed response. I have created testing guides (linked at the bottom of the main README.md of the project) for the milestone's deliverables, and I went ahead and added unit tests that can simply be run to verify their functionality.

Regarding the protocols, some parts are designed to be offloaded to other blockchains that want to use the project, so there wouldn't be any implementation present in the repository to point to. Furthermore, the revocation protocol will be fully implemented in the third milestone, so I will update the links to point to it then. I have however added links to the relevant code snippets that contribute to each protocol under their respective sections within the README.md.

Let me know if anything is missing, and if these changes are what you expected!

[khalidzahra]

Hey @PieWol, sorry for the delay! I have added scripts to help in launching the architecture and to also set it up with some data for testing purposes. I updated the testing guides to include how the architecture can be launched as well. Let me know if this is what you were looking for!

[semuelle]

Hey @khalidzahra, sorry for the wait. I will take over the evaluation for Piet while he's out. I'll get back to you with feedback as soon as possible.

[PieWol]

Hey @khalidzahra ,
thanks for the updates. I'm finally back from vacation and took a look already. Sadly the unit tests are currently failing. I updated my evaluation accordingly. Let me know whats wrong. Once this is resolved I'll proceed with the actual testing with a deployed node.

[khalidzahra]

Hey @PieWol, thanks for catching that. There was some mismatch between module names which was causing the tests to fail, but I have fixed it and everything should run smoothly.

[PieWol]

Thanks, that worked 👍 . Now when I try to run the setup script somehow all registrations are failing. What am I missing?

go run init.go --init
Launching architecture using settings:
 {tlds:1 networks:2 validators:2 normal_nodes:2}
launch_dns_arch.sh: Authorities updated successfully.
Convert chain specifications to raw format.
Removing root_node1...
Removing root_node2...
Removing root_node3...
Removing root_node4...
Starting root_node1...
Starting root_node2...
Authorities updated successfully.
Convert chain specifications to raw format.
Removing com_tld_node1...
Removing com_tld_node2...
Removing com_tld_node3...
Removing com_tld_node4...
Starting com_tld_node1...
Starting com_tld_node2...
Authorities updated successfully.
Convert chain specifications to raw format.
Removing example_node1...
Removing example_node2...
Starting example_node1...
Starting example_node2...
Authorities updated successfully.
Convert chain specifications to raw format.
Removing whatever_node1...
Removing whatever_node2...
Starting whatever_node1...
Starting whatever_node2...
All specs have been created and are available at ./all_specs

Successfully launched DNS architecture.
Setting up DNS information...Error executing command: exit status 1
Registered COM TLD. Output: 
> dns_client@1.0.0 register
> node register.js --tld com ../polkadot-sdk-solochain-template/all_specs/com_tldSpec.json //Alice

Connecting to network root with boot nodes: /ip4//tcp/9945/p2p/12D3KooWNL4mZo8y7oAes3VRRnbHy91TDLxnjrDsnMFZkPebB2Rh,/ip4//tcp/9945/p2p/12D3KooWNL4mZo8y7oAes3VRRnbHy91TDLxnjrDsnMFZkPebB2Rh
Trying to connect to /ip4//tcp/9945/p2p/12D3KooWNL4mZo8y7oAes3VRRnbHy91TDLxnjrDsnMFZkPebB2Rh

Error executing command: exit status 1
Registered org TLD. Output: 
> dns_client@1.0.0 register
> node register.js --tld org ../polkadot-sdk-solochain-template/all_specs/com_tldSpec.json //Alice

Connecting to network root with boot nodes: /ip4//tcp/9945/p2p/12D3KooWNL4mZo8y7oAes3VRRnbHy91TDLxnjrDsnMFZkPebB2Rh,/ip4//tcp/9945/p2p/12D3KooWNL4mZo8y7oAes3VRRnbHy91TDLxnjrDsnMFZkPebB2Rh
Trying to connect to /ip4//tcp/9945/p2p/12D3KooWNL4mZo8y7oAes3VRRnbHy91TDLxnjrDsnMFZkPebB2Rh

Error executing command: exit status 1
Registered net TLD. Output: 
> dns_client@1.0.0 register
> node register.js --tld net ../polkadot-sdk-solochain-template/all_specs/com_tldSpec.json //Alice

[khalidzahra]

Hey @PieWol, I ran the scripts and they seem to work just fine on my end. The only thing that you might be missing is that you must build the node first using cargo before running the scripts. Can you confirm that you have done that?

[PieWol]

Hey @khalidzahra ,
I did build the node, strictly following your written instructions. Yet even though I now tried the whole process on a local machine to outrule any firewall issues, I still get the same error.

[PieWol]

I'm assuming that building the node and then executing the init.go script will take care of everything. Is there anything else that needs to be done prior to executing the script?

[khalidzahra]

Hi @PieWol, sorry about all the trouble with running the script. I believe the problem probably lies in the dependencies of the DNS client not being installed. I pushed an update that makes init.go take care of it, but if you want to use the version that you currently have, you can simply run npm install in the dns_client directory before running init.go.

[PieWol]

I gave it a fresh setup after your commit but it still fails. Manually executing npm install in the dns_client directory doesn't help either.

Do you want to keep it async to get a hold of this issue or do want to resolve it with me in a quick meeting? If so feel free to book a slot in my calendar. I think you should have the link to it in some email thread of ours.

[khalidzahra]

Let's hop into a quick meeting. I will book a slot on your calendar.

[khalidzahra]

Hi @PieWol, I have pushed a fix to solve the issues with running the node containers. The architecture should now successfully launch on the virtual machine.

[PieWol]

Thanks, all working!

[PieWol]

Happy to let you know that the delivery is now accepted. Please invoice the foundation as defined in our private contract.

[github-actions]

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!