TCDT Milestone 3

[khalidzahra]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• This pull request is being made by the same account as the accepted application.
• I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
• In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: Private application. Project name: tcdt

[khalidzahra]

Hey @PieWol, I added an overview for the incentive mechanism to the readme of the project as we discussed.

[PieWol]

Hey @khalidzahra ,
thanks for the update. Sadly unit testing of the pallets are currently failing

running 18 tests
test mock::__construct_runtime_integrity_test::runtime_integrity_tests ... ok
test mock::test_genesis_config_builds ... ok
test tests::register_domain_works ... ok
test tests::amend_chainspec_works ... ok
test tests::revoke_domain_works ... ok
test tests::test_accept_transfer ... ok
test tests::test_initiate_transfer ... ok
test tests::test_accept_transfer_no_permission ... ok
test tests::test_initiate_transfer_no_permission ... ok
test tests::test_domain_expiry_check ... ok
test tests::test_report_missed_heartbeat ... ok
test tests::test_revoke_transfer ... ok
test tests::test_report_missed_heartbeat_no_missed ... ok
test tests::test_report_missed_heartbeat_duplicate ... ok
test tests::test_send_heartbeat ... FAILED
test tests::test_send_heartbeat_not_maintainer ... ok
test tests::test_send_heartbeat_too_soon ... ok
test tests::test_threshold_revocation ... ok

failures:

---- tests::test_send_heartbeat stdout ----

thread 'tests::test_send_heartbeat' panicked at pallets/tld/src/tests.rs:337:9:
Expected Ok(_). Got Err(
    Module(
        ModuleError {
            index: 1,
            error: [
                14,
                0,
                0,
                0,
            ],
            message: Some(
                "HeartbeatTooSoon",
            ),
        },
    ),
)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    tests::test_send_heartbeat

test result: FAILED. 17 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s

error: test failed, to rerun pass `-p pallet-tld --lib`
ubuntu@ip-172-31-22-83:~/bcdns/polkadot-sdk-solochain-template$ git status
On branch milestone_3
Your branch is up to date with 'origin/milestone_3'.

[khalidzahra]

Hey @PieWol, thanks for catching that. I was playing around with the interval times and forgot to change it in the test as well. Everything should now be in order.

[PieWol]

Thanks for the delivery. I'm happy to let you know that it's now accepted. See here for the evaluation.

[github-actions]

🪙 Please fill out the invoice form in order to initiate the payment process. Please make sure that you follow the instructions and requirements as laid out in the form as well as our Terms & Conditions. Thank you!