-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Zkverse application #1563
Add Zkverse application #1563
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @VegeBun-csj. Thank you for your application. I have a couple of follow-up questions:
- Are you planning to use these pallets yourself, or have you talked to anyone personally who would use them?
- You state that your project will "do more education" than the ZK-Snarks tutorial, but there are no education-related deliverables in your roadmap. If you meant the 0e deliverables (article/workshop), it would be great if you could expand their specification a bit. Given the price of the grant, I think it'd be justified to include detailed workshops from an introduction to zkp to implementation of example proofs.
- You already listed some similar projects, but did you check our tech stack for other, existing implementations?
FYI, the Zeropool project is still active.
@semuelle Thank you for your reply and guiding suggestions, and I will answer your questions separately.
Yes, I will also use this Pallet after developed. Also, we have talked with some developers before. They will also hope to develop some zkp dapps in Polkadot ecosystem. But at present, the threshold of using some zkp libraries is a little high, so we have made this project based on this pain point. I think we will promote it after we make it, and there should be many people interested. Because we will combine some relatively friendly libraries to facilitate developers.
Thank you for your suggestion. I have pushed the latest commit which involve the detailed plans of eucation. Also, Our example is not a simple circuit like
Yes, i have seen many similar projects, they do not implement our ideas. Our main idea is to make some libraries that are easy for developers to write circuit and generate zkp proof (such as snarkjs) compatible with some zkp libraries integrated on the substrate-based chain (these libraries need to develop relatively low-level circuits, which are not very friendly for developers to develop circuits and easy to make mistakes). At present, many projects use one library for proof generation and verification, so we did what they didn't do, which is developer friendly. I just saw that they do have new actions, but their code base is relatively old. We intend to be compatible with the latest zkp library. In the future, we will also update Pallet to maintain the latest version compatibility with substrate and support developers. In the future, we will support more ZKP proof systems |
applications/zkverse.md
Outdated
| **0b.** | Documentation | We will provide both **inline documentation** of the code and a basic **tutorial** that explains how a user can (for example) spin up one of our Substrate nodes and send test transactions, which will show how the new functionality works. | | ||
| **0c.** | Testing and Testing Guide | Core functions will be fully covered by comprehensive unit tests to ensure functionality and robustness. In the guide, we will describe how to run these tests. | | ||
| **0d.** | Docker | We will provide a Dockerfile(s) that can be used to test all the functionality delivered with this milestone. | | ||
| 0e. | Article | We will publish an **article**/workshop to explain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that you have an "education" deliverable in each milestone, I'd say it makes sense to remove this article. Focus on the education part instead and, ideally, publish an article introducing the project separately for M2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that you have an "education" deliverable in each milestone, I'd say it makes sense to remove this article. Focus on the education part instead and, ideally, publish an article introducing the project separately for M2.
thanks, i have modified it according to your suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, @VegeBun-csj. I am generally happy to proceed. I would just like to ask you to add the deliverables 0b (at least inline documentation) and 0c from our template to both milestones, potentially also 0d (Docker) if the test setup is complex.
Thank you very much for your suggestion. I reduced the amount of first milestone a little. Although I have completed some work before, it has not been standardized and there are still many parts to be optimized, such as the adapter and the part of integrating pallet needs to be added and improved, eg: further developing pallet and optimize, version upgrade, function tests and some benchmarks. There is still a lot of work. At the same time, We also add relevant educational content. It is not a simple example, such as Simple operation, but a more practical example (such as rollup or the other) to show devs how to use our tools to develop a more practical zk dapps. As I said above, our implementation is better and more general, this feature is very meaningful :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update and the price reduction. However, the current delivery for the first milestone could basically be a copy of the work done here based on the current specification. So I’m personally unwilling to accept it at this price point and given the current level of details, but others might have a different opinion.
Kindly ping @Noc2. Thanks for your reply sincerely, but our implementation is not a copy. It is different from the details of the implementation. Can you reconsider my updated price reduction? |
Hi sir. I have reduced the price of milestone1 again. Can you take a look for my application?😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. But you changed the total costs of the first milestone to 70k USD (= 70,000). Was this intentional?
@Noc2. No offense. I'm very sorry, sir. I didn't mean to. In the previous modification, my total amount was reduced, so the price of milestone1 is caused by carelessness. I'm very sorry for it. I have revised my application, listen to your suggestions Sincerely. Please forgive that brings you the inconvenience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. I'm happy to go ahead with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the application @VegeBun-csj and for the deep dive @semuelle @Noc2 sounds like an interesting project. Hopefully these libraries will make zkp easier for devs. Happy to go forward with it also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VegeBun-csj I'm happy to support the project. The only part that I think you should be aware of is to focus more on the parts not covered for zk-SNARKs grant, i.e., bellman, plonk, etc, and when explaining the similar parts try to perform it with a different approach with different examples. I think this is a very useful project.
Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions. |
* add some web3 grant info * add paln info * Update zkverse.md * Update zkverse.md * add Entity * complete zkverse * update project name * update * update * add some education * delete some doc * delete some doc * delete * update * update * update * update * Update * update
Hi @VegeBun-csj how is milestone 2 coming along? |
pinging @VegeBun-csj |
Hi @VegeBun-csj if we don't hear back within 2 weeks we will close the grant due to inactivity. Let me know if you have any questions regarding this. |
Project Abstract
At present, ZKP technology is constantly developing and innovating in the scaling and expansion track in Ethereum, especially some zk rollup projects, such as zksync, scroll, starknit, etc. So the main goal of this project is to introduce ZKP technology into the Polkadot/Substrate ecosystem. Polkadot/Substrate natively does not support ZKP, so this project(Zkverse, which means zk universe) will provide zk-related pallets to support substrate and more efficient zk proof generation ways.
There are three main goals for project:
Meanwhile, We know that snakjs and circom are excellent and popular zkp development libraries. They are very popular in the Ethereum ecosystem and can automatically generate verification contract codes. We observed this very good feature, so we want to generate circuit codes more easily through circom, and generate proofs by snarkjs, which will be verified on substrate-based chain. Due to many people using snakjs, and circom is developer friendly, Unlike some domain-specific circuit writing methods, our project can attract many developers who are familiar with snarkjs to develop zkp Dapps in substrate/polkadot ecosystem. They can also enjoy the convenience of developing zkp applications in Polkadot ecosystem. So our main goal is to provide zkp infrastructure that is convenient for Polkadot developers. Also ,we will show a minimal example with Merkle tree and ZKP for rollup.
Grant level
Application Checklist
project_name.md
).@_______:matrix.org
(change the homeserver if you use a different one)