Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve aggregate public key handling in musig #12

Open
burdges opened this issue Feb 13, 2019 · 1 comment
Open

Improve aggregate public key handling in musig #12

burdges opened this issue Feb 13, 2019 · 1 comment
Labels
good first issue Good for newcomers

Comments

@burdges
Copy link
Collaborator

burdges commented Feb 13, 2019

First, how should we expose the aggregate public key method for multi-signatures?

We currently have some tools to compute public keys form slices of public keys, as well as to expose the aggregate public key counting all revealed participants. We currently lack tests to ensure these agree, but beyond this should we add methods to answer queries about the aggregate public keys at each stage? Or would this be confusing?

Second, should we error when users attempt to progress form one stage to another without the aggregate public key being correct?

We'd improve errors if users attempted to put themselves into irrecoverable states. We do want a remove method for public keys that abandon the protocol. We call compute_R in cosign_stage so deletion cannot happen after people enter that stage. Yet, doing too much may limit the utility, like by preventing users from creating their R shares in advance.

Third, should protocol messages communicate the signer list and/or be signed?

We need agreement on the set of cosigners of course, but initially I wanted to be agnostic to the agreement technique.

As an aside, there are likely strange attacks without the commit phase, like Eve might join Eve-Alice and Eve-Bob, but the commit stage prevents these.

@burdges burdges changed the title How should we expose the aggregate public key method for multi-signatures? Improve aggregate public key handling Feb 13, 2019
@burdges
Copy link
Collaborator Author

burdges commented Feb 13, 2019

We should likely sign the last message along with the list of public keys that revealed correctly.

@burdges burdges changed the title Improve aggregate public key handling Improve aggregate public key handling in musig Feb 13, 2019
@burdges burdges added the good first issue Good for newcomers label May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant