Merge pull request #458 from walles/johan/go-1.27

Bump Go to 1.27

Author: walles

cmd/moor/alt-screen_test.go

@@ -19,8 +19,7 @@ func TestLongInputUsesAlternateScreen(t *testing.T) {
 		t.Run(fmt.Sprintf("fromPipe=%t", fromPipe), func(t *testing.T) {
 			options := moorOptions{answerBackgroundQuery: true}
 			if fromPipe {
-				hundredLines := textLines(100)
-				options.stdin = &hundredLines
+				options.stdin = new(textLines(100))
 			} else {
 				options.args = []string{createTextFile(t, 100)}
 			}
@@ -119,8 +118,7 @@ func TestQuitIfOneScreenNeverEntersAlternateScreen(t *testing.T) {
 					args:                  []string{"--quit-if-one-screen"},
 				}
 				if fromPipe {
-					twoLines := "hello world 1\nhello world 2\n"
-					options.stdin = &twoLines
+					options.stdin = new("hello world 1\nhello world 2\n")
 				} else {
 					options.args = append(options.args, createTextFile(t, 2))
 				}
@@ -170,8 +168,7 @@ func TestQuitIfOneScreenNeverEntersAlternateScreenWhenHighlighted(t *testing.T)
 					args:                  []string{"--quit-if-one-screen"},
 				}
 				if fromPipe {
-					lines := jsonLines(lineCount, marker)
-					options.stdin = &lines
+					options.stdin = new(jsonLines(lineCount, marker))
 				} else {
 					options.args = append(options.args, createSourceFile(t, lineCount, marker))
 				}

cmd/moor/moor.go

@@ -628,8 +628,7 @@ func pagerFromArgs(
 
 	pager.TargetLine = targetLine
 	if *follow && pager.TargetLine == nil {
-		reallyHigh := linemetadata.IndexMax()
-		pager.TargetLine = &reallyHigh
+		pager.TargetLine = new(linemetadata.IndexMax())
 	}
 
 	return pager, screen, style, &formatter, logsRequested, nil

cmd/moor/plusparser.go

@@ -59,15 +59,13 @@ func parseLineNumber(withoutPlus string) *linemetadata.Index {
 		lineNumber = 1
 	}
 
-	targetIndex := linemetadata.IndexFromOneBased(int(lineNumber))
-	return &targetIndex
+	return new(linemetadata.IndexFromOneBased(int(lineNumber)))
 }
 
 func parseSearchPattern(withoutPlus string) *string {
 	if !strings.HasPrefix(withoutPlus, "/") {
 		return nil
 	}
 
-	pattern := withoutPlus[1:]
-	return &pattern
+	return new(withoutPlus[1:])
 }

go.mod

@@ -1,6 +1,6 @@
 module github.com/walles/moor/v2
 
-go 1.25.0
+go 1.27.0
 
 require (
 	github.com/adrg/xdg v0.5.3

internal/editor.go

@@ -118,8 +118,7 @@ func middleVisibleLine(p *Pager) *linemetadata.Index {
 		return nil
 	}
 
-	middle := lines[len(lines)/2].inputLineIndex
-	return &middle
+	return new(lines[len(lines)/2].inputLineIndex)
 }
 
 // check if the editor can accept "+LINENUMBER" argument

internal/file-switching_test.go

@@ -25,11 +25,9 @@ func TestIssue426SwitchingToSmallerFileClearsStaleScrollPosition(t *testing.T) {
 
 	// This matches the stale post-switch state from issue #426: the reader has
 	// moved to a shorter file, but the scroll position still points below it.
-	staleIndex := linemetadata.IndexFromZeroBased(70)
-	staleIndexPtr := &staleIndex
 	pager.scrollPosition = scrollPosition{
 		internalDontTouch: scrollPositionInternal{
-			lineIndex: staleIndexPtr,
+			lineIndex: new(linemetadata.IndexFromZeroBased(70)),
 			delta:     0,
 			name:      "Issue 426 stale file switch",
 		},

internal/filteringReader_test.go

@@ -59,10 +59,9 @@ func BenchmarkFilterHugeFile(b *testing.B) {
 	input := reader.NewFromTextForTesting("BenchmarkFilterHugeFile()", text)
 	assert.NilError(b, input.Wait())
 
-	filterTerm := search.For("Periodic")
 	fr := FilteringReader{
 		BackingReader: input,
-		Filter:        &filterTerm,
+		Filter:        new(search.For("Periodic")),
 	}
 	fr.rebuildCache() // warmup
 

internal/pager.go

@@ -263,8 +263,7 @@ func NewPager(readers ...*reader.ReaderImpl) *Pager {
 		Filter:        &pager.filter,
 	}
 
-	searchHistory := BootSearchHistory("")
-	pager.searchHistory = &searchHistory
+	pager.searchHistory = new(BootSearchHistory(""))
 
 	return &pager
 }
@@ -471,8 +470,7 @@ func (p *Pager) handleScrolledUp() {
 func (p *Pager) handleScrolledDown() {
 	if p.isScrolledToEnd() {
 		// Follow output
-		reallyHigh := linemetadata.IndexMax()
-		p.setTargetLine(&reallyHigh)
+		p.setTargetLine(new(linemetadata.IndexMax()))
 	} else {
 		p.setTargetLine(nil)
 	}

internal/pager_test.go

@@ -772,8 +772,7 @@ func TestHandleMoreLinesAvailableWithEmptyFile(t *testing.T) {
 	pager := NewPager(emptyReader)
 
 	// Simulate --follow mode by setting target to max
-	targetLine := linemetadata.IndexMax()
-	pager.TargetLine = &targetLine
+	pager.TargetLine = new(linemetadata.IndexMax())
 
 	// This should not crash when lineCount is 0
 	pager.handleMoreLinesAvailable()

internal/pagermode-viewing.go

@@ -173,16 +173,14 @@ func (m PagerModeViewing) onRune(char rune) {
 		p.search.Clear()
 
 		// Searchers want to scan the whole file, start reading as much as we can
-		reallyHigh := linemetadata.IndexMax()
-		p.setTargetLine(&reallyHigh)
+		p.setTargetLine(new(linemetadata.IndexMax()))
 
 	case '?':
 		p.mode = NewPagerModeSearch(p, SearchDirectionBackward, p.scrollPosition)
 		p.search.Clear()
 
 		// Searchers want to scan the whole file, start reading as much as we can
-		reallyHigh := linemetadata.IndexMax()
-		p.setTargetLine(&reallyHigh)
+		p.setTargetLine(new(linemetadata.IndexMax()))
 
 	case '&':
 		if !p.isShowingHelp {