update playwright fixes for finetuning

Signed-off-by: wwanarif <[email protected]>

Author: wanhakim

studio-frontend/packages/ui/src/views/finetuning/FinetuningJobsTable.jsx

@@ -124,6 +124,7 @@ const FinetuningJobsTable = ({ data, isLoading = false, onRefresh = null, filter
     const [logsOpen, setLogsOpen] = useState(false)
     const [logsData, setLogsData] = useState('')
     const [logsLoading, setLogsLoading] = useState(false)
+    const [deleteConfirmOpen, setDeleteConfirmOpen] = useState(false)
     const logsContainerRef = useRef(null)
 
     // Auto-refresh logs every 3 seconds when logs dialog is open
@@ -687,18 +688,7 @@ const FinetuningJobsTable = ({ data, isLoading = false, onRefresh = null, filter
                 <MenuItem 
                     onClick={async () => { 
                         if (!selectedJob) return
-                        if (!window.confirm('Are you sure you want to delete this job?')) return
-                        setActionLoading(true)
-                        try {
-                            await finetuningApi.deleteJob(selectedJob.id)
-                            handleMenuClose()
-                            if (onRefresh) onRefresh()
-                        } catch (error) {
-                            console.error('Error deleting job:', error)
-                            alert('Failed to delete job: ' + (error.message || 'Unknown error'))
-                        } finally {
-                            setActionLoading(false)
-                        }
+                        setDeleteConfirmOpen(true)
                     }}
                     disabled={actionLoading}
                 >
@@ -768,6 +758,43 @@ const FinetuningJobsTable = ({ data, isLoading = false, onRefresh = null, filter
                     </Button>
                 </DialogActions>
             </Dialog>
+
+            {/* Delete Confirmation Dialog */}
+            <Dialog open={deleteConfirmOpen} onClose={() => setDeleteConfirmOpen(false)} maxWidth="xs" fullWidth>
+                <DialogTitle>Delete Job</DialogTitle>
+                <DialogContent>
+                    <Typography variant="body2">
+                        Are you sure you want to delete this job? This action cannot be undone.
+                    </Typography>
+                </DialogContent>
+                <DialogActions>
+                    <Button onClick={() => setDeleteConfirmOpen(false)}>
+                        Cancel
+                    </Button>
+                    <Button 
+                        onClick={async () => {
+                            if (!selectedJob) return
+                            setActionLoading(true)
+                            try {
+                                await finetuningApi.deleteJob(selectedJob.id)
+                                setDeleteConfirmOpen(false)
+                                handleMenuClose()
+                                if (onRefresh) onRefresh()
+                            } catch (error) {
+                                console.error('Error deleting job:', error)
+                                alert('Failed to delete job: ' + (error.message || 'Unknown error'))
+                            } finally {
+                                setActionLoading(false)
+                            }
+                        }}
+                        color="error"
+                        variant="contained"
+                        disabled={actionLoading}
+                    >
+                        Delete
+                    </Button>
+                </DialogActions>
+            </Dialog>
         </>
     )
 }

tests/playwright/studio-e2e/005_test_funetuning_rerank.spec.ts

@@ -64,5 +64,5 @@ test('005_test_funetuning_rerank', async ({ browser, baseURL }) => {
 
     await page.locator('button').nth(5).click();
     await page.getByRole('menuitem', { name: 'Delete Job' }).click();
-
+    await page.getByRole('button', { name: 'Delete', exact: true }).click();
 });

tests/playwright/studio-e2e/006_test_funetuning_embedding.spec.ts

@@ -64,5 +64,5 @@ test('006_test_funetuning_embedding', async ({ browser, baseURL }) => {
 
     await page.locator('button').nth(5).click();
     await page.getByRole('menuitem', { name: 'Delete Job' }).click();
-
+    await page.getByRole('button', { name: 'Delete', exact: true }).click();
 });

tests/playwright/studio-e2e/007_test_funetuning_reasoning.spec.ts

@@ -64,6 +64,5 @@ test('007_test_funetuning_reasoning', async ({ browser, baseURL }) => {
 
     await page.locator('button').nth(5).click();
     await page.getByRole('menuitem', { name: 'Delete Job' }).click();
-
-    
+    await page.getByRole('button', { name: 'Delete', exact: true }).click();
 });