Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Control usernames in teamSpeak #40

Open
tigranm75 opened this issue Sep 14, 2020 · 9 comments
Open

[Feature request] Control usernames in teamSpeak #40

tigranm75 opened this issue Sep 14, 2020 · 9 comments
Labels
drivers/teamspeak Teamspeak driver related issues enhancement New feature or request

Comments

@tigranm75
Copy link

Hi!

Please add nickname control mechanism to TS plugin. It can check by cron username in TS and kick users who don't meet username format requirements like discord "[%1$s] %2$s" with message "Your nickname must be [%1$s] %2$s"

Thank you!

@Nfinished
Copy link

Nfinished commented Sep 14, 2020

As far as I know, Alliance Auth manages to exert direct control over Teamspeak users' names. Is that something SeAT could achieve? Alternatively, it doesn't seem to be too much of a security issue to have users join programmatically with their correct name rather than a uid.

Caveat: Prefixes may not be as desirable for Teamspeak as they are for discord/discourse, since they can instead be set via Teamspeak group.

@warlof
Copy link
Owner

warlof commented Nov 10, 2020

Teamspeak API does not allow client user to be altered, in any way.
Also, adding a specific rule for a driver would impact other driver, which is not expected.

We may implement a kick action on the update nickname flow for teamspeak, that's a working use case. But it seems a little bit hard for that poor boy, no ?

@warlof warlof added drivers/other Driver related issues enhancement New feature or request drivers/teamspeak Teamspeak driver related issues labels Nov 10, 2020
@tigranm75
Copy link
Author

We may implement a kick action on the update nickname flow for teamspeak, that's a working use case. But it seems a little bit hard for that poor boy, no ?

I think it's normal. Most of big alliances use that algorithm and people are familiar with that mechanic.

@tribulex
Copy link

It would be great to have the option to assign the user the correct name on initial login rather than a random series of characters. This way the onus is not on the user to change their name to a perfect format.

@Nfinished
Copy link

Nfinished commented Nov 11, 2020 via email

@tribulex
Copy link

If it is an option, accepting the risk is up to the person running the service.

@warlof warlof removed the drivers/other Driver related issues label Nov 15, 2020
@akturis
Copy link
Contributor

akturis commented Dec 25, 2020

ServerQuery can update the client description (clientdbedit cldbid=$ client_description=$).
The plugin can save the username with tag there.

@teh-banana
Copy link

Could we have an option to have SeAT continue to authenticate how it currently does (random letters / numbers), and then when running seat-connector:apply:policies drop server groups if the users nickname does not match the specified format. Having an option specific for TeamSpeak for this to be on/off would be ideal for people who want to continue using it as is.

@warlof
Copy link
Owner

warlof commented Sep 13, 2021

@teh-banana I had spawn that at some time - but never be able to valid its flow : warlof/seat-teamspeak#25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
drivers/teamspeak Teamspeak driver related issues enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants