refactor: change token and account coupling system #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new approach at user enrollment flow.
Instead asking SeAT to generate a random token, we ask Teamspeak to provide us one that we will use to bind the SeAT account to a Teamspeak account. This capability is provided by Teamspeak user custom information - as per this valuate post.
User will join Teamspeak server using his main character name and consume the provided token.
In case the user don't have teampseak client mapped to
ts3server://protocol, we still show him the privilege token, so he will be able to manually set his account.Before user being redirected to the authentication modal, we kick and remove all mapped account. Prior, this step was done after redirection.
BREAKING CHANGES
This feature is requesting to define a server group which will be used during enrollment flow. This Server Group will be used by the token, and removed as soon as policy are applied (except if you also grant that server group on your policy)