change default minOcurrences to 3; small code clean up

Author: meowbmw

plugins/rules/memberAccess.ts

@@ -51,11 +51,11 @@ const noRepeatedMemberAccess = createRule({
         "Member chain '{{ chain }}' accessed {{ count }} times. Extract to variable.",
     },
   },
-  defaultOptions: [{ minOccurrences: 2 }],
+  defaultOptions: [{ minOccurrences: 3 }],
 
   create(context, [options]) {
     const sourceCode = context.sourceCode;
-    const minOccurrences = options?.minOccurrences ?? 2;
+    const minOccurrences = options.minOccurrences;
 
     // Track which chains have already been reported to avoid duplicate reports
     const reportedChains = new Set<string>();
@@ -193,7 +193,7 @@ const noRepeatedMemberAccess = createRule({
       return result;
     }
 
-    // Tracks which chains are modified in code to avoid incorrect optimizations
+    // Tracks which chains are modified in code
     //
     // Examples of modifications:
     // 1. obj.prop = value;     // Direct assignment
@@ -259,9 +259,6 @@ const noRepeatedMemberAccess = createRule({
         // Skip single-level chains
         if (!chain.includes(".")) continue;
 
-        // Skip any chain that contains array access
-        if (chain.includes("[") && chain.includes("]")) continue;
-
         const record = scopeData.chains.get(chain) || {
           count: 0,
           nodes: [],

tests/rules/noRepeatedMemberAccess.test.ts

@@ -193,6 +193,7 @@ export namespace Constants {
           code: `
               const v1 = ctx.data.v1;
               const v2 = ctx.data.v2;
+              const v3 = ctx.data.v3;
               `,
           errors: [{ messageId: "repeatedAccess" }],
         },
@@ -210,6 +211,7 @@ export namespace Constants {
           constructor() {
             this.profile = service.user.profile
             this.log = service.user.logger
+            this.cat = service.user.cat
           }
         }`,
           errors: [{ messageId: "repeatedAccess" }],
@@ -219,6 +221,7 @@ export namespace Constants {
           code: `
         function demo() {
           console.log(obj.a.b.c);
+          let x = obj.a.b;
           return obj.a.b.d;
         }
       `,