Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] build (and test?) release docker images on each PR #621

Closed
rvolosatovs opened this issue May 8, 2023 · 1 comment
Closed

[FEATURE] build (and test?) release docker images on each PR #621

rvolosatovs opened this issue May 8, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed stale

Comments

@rvolosatovs
Copy link
Member

Is your feature request related to a problem? Please describe.
In #616 some changes were made to release pipeline and the only thing blocking actually building these images on each PR is the fact that the tagging functionality assumes that it's running on a tagged release, which is not the case (see TODO

# TODO: Build on PRs and pushes to main (but do not push)
# This is currently blocked on the `app-version` computation, which only supports semver tags
# E.g.:
# ```
# Error: buildx failed with: ERROR: invalid tag "wasmcloud.azurecr.io/wasmcloud_host:616/merge": invalid reference format
# ```
)

Describe the solution you'd like
Fix the tagging logic, maybe only apply the "git tag" tags on tag builds? Would be cool to also run these resulting images, but that could be a follow-up

@rvolosatovs rvolosatovs added enhancement New feature or request help wanted Extra attention is needed labels May 8, 2023
@stale
Copy link

stale bot commented Jul 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud!

@stale stale bot added the stale label Jul 7, 2023
@stale stale bot closed this as completed Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed stale
Projects
None yet
Development

No branches or pull requests

1 participant