Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy Button does is not a11y friendly #723

Closed
lachieh opened this issue Nov 20, 2024 · 3 comments · Fixed by #775
Closed

Copy Button does is not a11y friendly #723

lachieh opened this issue Nov 20, 2024 · 3 comments · Fixed by #775
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed react

Comments

@lachieh
Copy link
Contributor

lachieh commented Nov 20, 2024

When there is text behind the code copy button, the text behind appears in front. This makes it difficult to see.

Screenshot 2024-11-20 at 1 16 06 PM
@lachieh lachieh added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed react labels Nov 20, 2024
@AntonAmbarov
Copy link
Contributor

What if you move the button to the header and increase the height of the header?
image

@lachieh
Copy link
Contributor Author

lachieh commented Jan 2, 2025

That's a good solution, @AntonAmbarov! Would you be interested in submitting a PR?

@AntonAmbarov AntonAmbarov mentioned this issue Jan 2, 2025
Merged
3 tasks
@AntonAmbarov
Copy link
Contributor

@lachieh Yeah, it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed react
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ensure copy button does not overlap code block text AntonAmbarov/wasmcloud.com
2 participants
@lachieh @AntonAmbarov