Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmer-cli: Crate zip version needs update #4807

Closed
a4lg opened this issue Jun 5, 2024 · 0 comments · Fixed by #4817
Closed

wasmer-cli: Crate zip version needs update #4807

a4lg opened this issue Jun 5, 2024 · 0 comments · Fixed by #4817
Assignees
Labels
priority-high High priority issue

Comments

@a4lg
Copy link

a4lg commented Jun 5, 2024

Describe the bug

wasmer-cli requires zip crate version 1.2.3 (or later 1.x.x) but all 1.2.x and 1.3.x releases of that crate were yanked due to SemVer-incompatible (breaking) changes in version 1.2.0 (zip-rs/zip2#124).

To fix that, zip crate started to use version numbers 2.x.x.

Steps to reproduce

Try to build wasmer-cli regularly (currently version 4.3.1).

cargo install wasmer-cli

Expected behavior

Build completes without any errors.

Actual behavior

It fails to compile due to the failure to find appropriate (compatible) zip crate.

    Updating crates.io index
  Installing wasmer-cli v4.3.1
    Updating crates.io index
error: failed to compile `wasmer-cli v4.3.1`, intermediate artifacts can be found at `/tmp/cargo-install******`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.

Caused by:
  failed to select a version for the requirement `zip = "^1.2.3"`
  candidate versions found which didn't match: 2.1.3, 2.1.2, 2.1.1, ...
  location searched: crates.io index
  required by package `wasmer-cli v4.3.1`
  if you are looking for the prerelease package it needs to be specified explicitly
      zip = { version = "0.10.0-alpha.1" }
  perhaps a crate was updated and forgotten to be re-vendored?

Additional context

It seems wasmer-cli is unaffected by those breaking changes in the zip crate (at least, the crate compiles) but I'm not sure whether just changing the version number would be a solution.

-zip = { version = "1.2.3", default-features = false, features = ["deflate"] }
+zip = { version = "2.1.3", default-features = false, features = ["deflate"] }

That's why I'm submitting this as an issue, not as a PR.

@a4lg a4lg changed the title wasmer-cli: Crate zip version wasmer-cli: Crate zip version needs update Jun 5, 2024
@syrusakbary syrusakbary added the priority-high High priority issue label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-high High priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants