-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cargo-watch reacts to IsFile
event, while it should not.
#242
Comments
This makes this bug platform version specific: it doesn't appear on Linux, and it doesn't appear on the old macbook air I have, which can't get upgraded to macOS 12.x Fixing the issue is probably best done upstream in notify as by the time it gets handled here, it's already reduced to one of only five categories. However, cargo-watch 8.x uses watchexec 1.17, which uses notify 4.x (the latest version is 5.0.0)... but it might be possible to have a patch release made for that release branch. Ask there. In the meantime, you can likely work around the issue by using |
@passcod thanks for the explanation. I created an issue in the notify repo. Regarding Is there anything I can do to help debugging it further? |
Wow I hadn't realised you were embedding cargo watch in your program. That's... not supported. I can't stop you, but this is not something that I would ever recommend doing. Use the libraries directly if you need to. Regardless:
|
@passcod we are not embedding it. We have a build script which basically downloads fonts to a folder, then compiles some C binaries, etc., end then runs Regarding the points that you mentioned:
|
Not really interested in debating what exactly counts as embedding. This isn't a gotcha or invalidating a support contract or whatever. Interactive use is the intended use. If your setup works for you, fine.
|
Hi @passcod, did you find time to take a look into this issue? :) |
No. Again, if you want it earlier, a PR is welcome. |
@passcod I totally understand it. Unfortunately, I don't have enough of time to contribute here, as it requires pretty in-depth debugging. While I find |
I'd say please don't use the name cargo-watch, but otherwise, best of luck |
I'm using |
Hi, I'm using
cargo-watch
8.1.1 (because 8.3.0 does not work for me). Recently, our build script, which uses cargo-watch under the hood, started looping indefinitely. After debugging it turned out, that when usingstd::fs::copy("a.txt", "b.txt")
on macOS, a file system eventIsFile
is sometimes emitted on the source file ("a.txt"
). The term "sometimes" is better explained here. Our build script is copying some files to target directory, which causes the sources to emit this event, which causescargo-watch
to re-run the whole operation again.System: macOS Monterey (12.0.1), M1 pro
The text was updated successfully, but these errors were encountered: