Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency management with Go modules #102

Closed
3 tasks
nexuhan opened this issue Jun 5, 2021 · 2 comments
Closed
3 tasks

Update dependency management with Go modules #102

nexuhan opened this issue Jun 5, 2021 · 2 comments
Assignees
@nexuhan
Labels
help wanted Extra attention is needed pr-exists

Comments

@nexuhan
Copy link
Member

nexuhan commented Jun 5, 2021

Current contribution guideline:

(...)
Dependencies are **not** checked in so please download those separately.
Download the dependencies using [`dep`](https://github.com/golang/dep).

dep is deprecated.

TODO

  • Replace dep uses in codebase with Go modules
  • Test changes
  • Update contribution guideline
@nexuhan nexuhan self-assigned this Jun 5, 2021
@nexuhan nexuhan mentioned this issue Jun 5, 2021
Closed
4 tasks
@nexuhan nexuhan added the help wanted Extra attention is needed label Jun 15, 2021
@github-actions
Copy link

This issue has been inactive for 60 days. If the issue is still relevant please comment to re-activate the issue. If no action is taken within 7 days, the issue will be marked closed.

@github-actions github-actions bot added the Stale label Aug 15, 2021
@toelke toelke reopened this Feb 12, 2024
@toelke toelke added pr-exists and removed Stale labels Feb 12, 2024
@toelke
Copy link
Collaborator

toelke commented Apr 26, 2024

Fixed with #145

@toelke toelke closed this as completed Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nexuhan nexuhan

Labels
help wanted Extra attention is needed pr-exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use go modules (WIP) wave-k8s/wave
2 participants
@toelke @nexuhan