Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wave Removes StartupProbes #137

Closed
jan-kantert opened this issue Jan 9, 2024 · 4 comments
Closed

Wave Removes StartupProbes #137

jan-kantert opened this issue Jan 9, 2024 · 4 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@jan-kantert
Copy link

If you add a startupProbe to any deployment/pod with a wave annotation that will be removed by wave. This is probably caused by an old version of the kubernetes API used in wave.
@starkers
Copy link

starkers commented Feb 1, 2024

Yes; I think you are right

@toelke
Copy link
Collaborator

toelke commented Feb 12, 2024

This is an understandable duplicate of #118

@toelke toelke added bug Something isn't working duplicate This issue or pull request already exists labels Feb 12, 2024
@jan-kantert
Copy link
Author

Will be fixed by #145

@toelke
Copy link
Collaborator

toelke commented Apr 26, 2024

Fixed with #145

@toelke toelke closed this as completed Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@toelke @starkers @jan-kantert