-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token Role Functions #10
Open
thesmall
wants to merge
13
commits into
master
Choose a base branch
from
bsmall_token_role_functions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds functions for listing, getting, updating, creating and deleting policies. Adds a function for generating policy documents. Adds a private function for deriving a specified TTL in seconds, given a string-formatted TTL that Vault recognizes. Increments psVaultUtils to 1.5.0. Adds new functions and aliases to the manifest file, and adds new aliases to the module file. Adds support for formatting objects containing policy information to Format-VaultOutput.
Adds functions Show-VaultKVSecret and Show-VaultTokenAccessor, which could previously not be created due to a lack of knowledge around how to query endpoints that utilize the LIST method, which Invoke-RestMethod does not support. Updates the README with this information, noting the PowerShell limitation of not being able to use LIST method. Updates the README with information about Show --> List aliasing. Updates the module/manifest file with new functions/aliases.
…n roles and functions used for authentication.
…ating, listing and deleting token roles.
…rsion of module to 1.7.1.
…le. Tweaks the wording for SupportsShouldProcess.
thesmall
requested review from
djraooney,
jeremypope,
kunista,
vijaygopala and
vbjustin
October 14, 2019 13:28
…to the code through rebases.
…ds example to Update-VaultTokenRole.
djraooney
suggested changes
Nov 15, 2019
'Get-VaultLoginToken' | ||
'Set-VaultLoginToken' | ||
|
||
#Token Management | ||
'Get-VaultToken' | ||
'New-VaultToken' | ||
'New-VaultWrappedToken' | ||
'Revoke-VaultToken' | ||
'Show-VaultTokenRole' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you want to remove this line since you reference it in the section below?
kunista
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Adds support for functions that can be used to interact with Token Roles.
Context
These changes continue to build out the utility of the module.
Changes
SupportsShouldProcess
toNew-
andUpdate-
token role functions.