refactor test imports and rollback methods for consistency

Standardize imports across test files by replacing inline React imports with named imports. Simplify code structure for readability by reformatting multiline arrays and conditionals.

Remove the «override» keyword from rollback methods in multiple classes to align with TypeScript conventions and ensure compatibility.

Improve readability in «derivePossibleCauses» by reformatting conditional checks for network issues.

These changes enhance code consistency, maintainability, and readability.

Author: guidomodarelli

public/dashboard-assistant/components/__tests__/model-register.test.tsx

@@ -3,15 +3,14 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import React from 'react';
+import React, { useState, useCallback, useEffect } from 'react';
 import userEvent from '@testing-library/user-event';
 import { render, screen, waitFor } from '../../../../test/test_utils';
+import { ExecutionState } from '../../modules/installation-manager/domain';
 
 jest.mock('../model-form', () => {
-  const React = require('react');
-
   const MockModelForm = ({ onChange, onValidationChange }: any) => {
-    React.useEffect(() => {
+    useEffect(() => {
       onChange?.({
         modelProvider: 'OpenAI',
         model: 'gpt-4o',
@@ -31,9 +30,6 @@ jest.mock('../model-form', () => {
 });
 
 jest.mock('../../modules/installation-manager/hooks/use-assistant-installation', () => {
-  const React = require('react');
-  const { ExecutionState } = require('../../modules/installation-manager/domain');
-
   const failedStep = {
     stepName: 'Create Model',
     state: ExecutionState.FAILED,
@@ -58,9 +54,9 @@ jest.mock('../../modules/installation-manager/hooks/use-assistant-installation',
   return {
     __esModule: true,
     useAssistantInstallation: () => {
-      const [error, setError] = React.useState<string | undefined>(undefined);
+      const [error, setError] = useState<string | undefined>(undefined);
 
-      const install = React.useCallback(async () => {
+      const install = useCallback(async () => {
         setError('Steps: "Create Model" has failed');
       }, []);
 

public/dashboard-assistant/modules/installation-manager/domain/entities/install-dashboard-assistant-response.test.ts

@@ -34,11 +34,10 @@ describe('InstallDashboardAssistantResponse', () => {
 
   it('failure() should accept rollbacks to describe reverted steps', () => {
     const progress = new InstallationProgress();
-    const res = InstallDashboardAssistantResponse.failure(
-      'Failed with rollbacks',
-      progress,
-      ['Create Connector', 'Persist ML Commons settings']
-    );
+    const res = InstallDashboardAssistantResponse.failure('Failed with rollbacks', progress, [
+      'Create Connector',
+      'Persist ML Commons settings',
+    ]);
 
     expect(res.rollbacks).toEqual(['Create Connector', 'Persist ML Commons settings']);
   });

public/dashboard-assistant/modules/installation-manager/domain/entities/installation-progress-manager.test.ts

@@ -125,9 +125,7 @@ describe('InstallationProgressManager', () => {
     ).rejects.toThrow('boom');
 
     expect(rollbackOrder).toEqual(['S3', 'S2', 'S1']);
-    expect(mgr.getRollbackErrors()).toEqual([
-      { step: 'S2', message: 'S2 rollback failed' },
-    ]);
+    expect(mgr.getRollbackErrors()).toEqual([{ step: 'S2', message: 'S2 rollback failed' }]);
   });
 
   it('prevents concurrent step execution', async () => {

public/dashboard-assistant/modules/installation-manager/infrastructure/steps/create-agent-step.ts

@@ -95,7 +95,7 @@ export class CreateAgentStep extends InstallationAIAssistantStep {
     return 'Failed to create agent. Please check the configuration and try again.';
   }
 
-  public override async rollback(
+  public async rollback(
     _request: InstallAIDashboardAssistantDto,
     context: InstallationContext,
     _error: Error

public/dashboard-assistant/modules/installation-manager/infrastructure/steps/create-connector-step.ts

@@ -72,7 +72,7 @@ export class CreateConnectorStep extends InstallationAIAssistantStep {
     return 'Failed to create connector. Please check the configuration and try again.';
   }
 
-  public override async rollback(
+  public async rollback(
     _request: InstallAIDashboardAssistantDto,
     context: InstallationContext,
     _error: Error

public/dashboard-assistant/modules/installation-manager/infrastructure/steps/create-model-step.ts

@@ -63,7 +63,7 @@ export class CreateModelStep extends InstallationAIAssistantStep {
     return 'Failed to create model. Please check the configuration and try again.';
   }
 
-  public override async rollback(
+  public async rollback(
     _request: InstallAIDashboardAssistantDto,
     context: InstallationContext,
     _error: Error

public/dashboard-assistant/modules/installation-manager/infrastructure/steps/register-agent-step.ts

@@ -48,7 +48,7 @@ export class RegisterAgentStep extends InstallationAIAssistantStep {
     return 'Failed to register agent. Please check the configuration and try again.';
   }
 
-  public override async rollback(
+  public async rollback(
     _request: InstallAIDashboardAssistantDto,
     _context: InstallationContext,
     _error: Error

public/dashboard-assistant/modules/installation-manager/infrastructure/steps/test-model-connection-step.ts

@@ -48,7 +48,8 @@ const extractStatusCode = (error: unknown): number | undefined => {
 const derivePossibleCauses = (error: unknown, modelId?: string): string[] => {
   const causes = new Set<string>();
   const status = extractStatusCode(error);
-  const message = error instanceof Error ? error.message.toLowerCase() : String(error).toLowerCase();
+  const message =
+    error instanceof Error ? error.message.toLowerCase() : String(error).toLowerCase();
 
   if (status === 401 || status === 403) {
     causes.add('Verify the API key; it may be incorrect or lack permissions.');
@@ -64,7 +65,9 @@ const derivePossibleCauses = (error: unknown, modelId?: string): string[] => {
 
   const indicatesNetworkIssue =
     !status &&
-    (error instanceof TypeError || message.includes('failed to fetch') || message.includes('network'));
+    (error instanceof TypeError ||
+      message.includes('failed to fetch') ||
+      message.includes('network'));
 
   if (indicatesNetworkIssue) {
     causes.add('Check the API URL for typos and ensure the endpoint is reachable.');
@@ -116,7 +119,7 @@ export class TestModelConnectionStep extends InstallationAIAssistantStep {
     return 'Failed to test model connection. Please check the model configuration and try again.';
   }
 
-  public override async rollback(
+  public async rollback(
     _request: InstallAIDashboardAssistantDto,
     _context: InstallationContext,
     _error: Error

public/dashboard-assistant/modules/installation-manager/infrastructure/steps/update-ml-commons-settings-step.ts

@@ -59,7 +59,7 @@ export class UpdateMlCommonsSettingsStep extends InstallationAIAssistantStep {
     return 'Failed to update ML Commons settings. Please check the configuration and try again.';
   }
 
-  public override async rollback(
+  public async rollback(
     _request: InstallAIDashboardAssistantDto,
     _context: InstallationContext,
     _error: Error