Feedback on rperl_installer.sh v 0.115_000

[lbe]

Will,

This is per our recent IIRC chat where you helped to me to get rperl to install correctly.

There are some things that the script does that I think could be improved. They are:

1. (20) It attempted to install a git and curl with apt-get that were already installed. I suggest that the script should check to see if the executables needs is already there - if ! [ -f $(which git) ]; then apt-get install git; fi

1a. (20) For the installs in #1, the script assumes it is running where apt is the package manager. This will fail if running on non-apt distributions such as RedHat and CentOS. I suggest writing a function that detects the distribution and package manager for the major distributions ( apt and yum ) so that you can don't fail in non-apt environments.

2. (20) I was able to complete your install and pass all rperl test with ExtUtils::MakeMaker 7.94 installed in my existing local::lib. I do not believe in directly updating the system wide perl when that is being managed via a package manager, such as apt in my case.

3. (25) Let people know ahead of time that pluto will install to /usr/local.

3a. (25) Your script currently downloads the pluto archive to the current working directory. It also expands it and creates a sub-directory in the current directory for the source and build. It leaves both of these behind. I suggest you use the mktemp facility to create a temporary directory in which to download, extract and build pluto and then rm -fR the directory afterwards.

4. (25) Per 1a, check to see what the distribution is and not generate prompts for Redhad/CentOS when on a Debian or Ubuntu system.

5. (26) The label for this option states install with CPAN when you actually used cpanm.

Thanks!

lbe

[wbraswell]

@lbe
I would love to have your help upgrading the RPerl installer program, including these same issues you have listed.
Please review the directions in the CONTRIBUTING file and let me know if you have any questions...