Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yalc push overrides --no-pure always #75

Open
iridiankin opened this issue Feb 15, 2019 · 1 comment · May be fixed by #105
Open

yalc push overrides --no-pure always #75

iridiankin opened this issue Feb 15, 2019 · 1 comment · May be fixed by #105

Comments

@iridiankin
Copy link

yalc.lock entry:

    "@what/ever": {
      "signature": "012344568987987",
      "file": true,
      "pure": false
    },

Will be replaced with "pure": true when @what/ever is yalc push because of the line:
https://github.com/whitecolor/yalc/blob/30d0cc7c933c41b71e578244b07538acae1085d6/src/update.ts#L54

Does not respect yalc.lock configuration at all, but unpreventably forces the --pure default via subsequent:

https://github.com/whitecolor/yalc/blob/30d0cc7c933c41b71e578244b07538acae1085d6/src/add.ts#L116

Says to use --no-pure, but --no-pure can't be given to yalc push, and earlier yalc add --no-pure is not respected.
@Blasz Blasz linked a pull request Oct 16, 2019 that will close this issue
Open
@itdhsc
Copy link

itdhsc commented Mar 25, 2024

That is a major problem for us - we always need to remove the line by hand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix yalc push always adding in pure mode for repos with workspaces Blasz/yalc
2 participants
@iridiankin @itdhsc