Skip to content

Commit ffce8e1

Browse files
committed
Make Pickers inherit from AppCompatDialogFragment
AppCompatDialogFragment inherits from DialogFragment, so this is not an API breaking change. However, styling of AppCompatDialogFragments works slightly different, so we should put a disclaimer in the release notes. The main advantage is that "dialogCornerRadius" is now correctly applied (previously only the API 28 attribute "android:dialogCornerRadius" would work) Fixes #588 Fixes #504
1 parent 2392d1a commit ffce8e1

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

library/src/main/java/com/wdullaer/materialdatetimepicker/date/DatePickerDialog.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
import androidx.annotation.ColorInt;
2929
import androidx.annotation.NonNull;
3030
import androidx.annotation.StringRes;
31-
import androidx.fragment.app.DialogFragment;
31+
import androidx.appcompat.app.AppCompatDialogFragment;
3232
import androidx.core.content.ContextCompat;
3333
import androidx.core.content.res.ResourcesCompat;
3434
import android.text.format.DateFormat;
@@ -59,7 +59,7 @@
5959
/**
6060
* Dialog allowing users to select a date.
6161
*/
62-
public class DatePickerDialog extends DialogFragment implements
62+
public class DatePickerDialog extends AppCompatDialogFragment implements
6363
OnClickListener, DatePickerController {
6464

6565
public enum Version {

library/src/main/java/com/wdullaer/materialdatetimepicker/time/TimePickerDialog.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
import androidx.annotation.NonNull;
3232
import androidx.annotation.Nullable;
3333
import androidx.annotation.StringRes;
34-
import androidx.fragment.app.DialogFragment;
34+
import androidx.appcompat.app.AppCompatDialogFragment;
3535
import androidx.core.content.ContextCompat;
3636
import androidx.core.content.res.ResourcesCompat;
3737
import android.util.Log;
@@ -61,7 +61,7 @@
6161
/**
6262
* Dialog to set a time.
6363
*/
64-
public class TimePickerDialog extends DialogFragment implements
64+
public class TimePickerDialog extends AppCompatDialogFragment implements
6565
OnValueSelectedListener, TimePickerController {
6666
private static final String TAG = "TimePickerDialog";
6767

@@ -258,6 +258,7 @@ public void setTitle(String title) {
258258
mTitle = title;
259259
}
260260

261+
@SuppressWarnings("unused")
261262
public String getTitle() {
262263
return mTitle;
263264
}

sample/src/main/res/values/styles.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
<item name="colorAccent">#ff4081</item>
99
<!-- Customize picker mode here. -->
1010
<item name="mdtp_theme_dark">true</item>
11+
<item name="dialogCornerRadius">10dp</item>
1112
</style>
1213

1314
</resources>

0 commit comments

Comments
 (0)