Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default backup strategy #140

Open
3 tasks
godjirax opened this issue Jan 21, 2022 · 2 comments
Open
3 tasks

Default backup strategy #140

godjirax opened this issue Jan 21, 2022 · 2 comments

Comments

@godjirax
Copy link
Contributor

godjirax commented Jan 21, 2022

On first ks use, ask user if he wants to have a backup strategy

ks <cmd>

Oh! I see you don't have any backup strategy!

Be carefull you are responsible for you secrets.
Keystone helps you to share secrets, not to restore if you loose them.

You can set a default backup strategy.
It will backup your projects secrets in `~/.config/keystone/backup` folder.

Do you want a default basic backup stragegy? y/n

n => No problem, keep it mind to setup one later!

y=> backup folder? (~/.config/keystone/backup)
  • Store in ~/.config/keystone.yaml user choice
  • Create default backup hook
  • Create cmd to restore one backup, without overriding project secrets for all users (current restore cmd)
@gaelph
Copy link
Contributor

gaelph commented Mar 22, 2022

Since there already are both ks backup and ks restore commands this new behaviour conflicts with the existing one. The existing ks backup and ks restore will be renamed to ks project backup and ks project restore respectively.

We’ll have:

  • ks backup to backup the current user secrets, if the user has setup a default backup strategy, set one up otherwise
  • ks restore restores the current user personal backup
  • ks project backup allows an admin to backup all secrets on all environments
  • ks project restore allows an admin to restore all secrets on all environments and share those with all project members

@godjirax how would a user change their backup strategy ? (change backup folder, or disable backups all together)

Also "default strategy" and "default basic strategy" suggest there could be other backup strategies… are there any ?

@gaelph
Copy link
Contributor

gaelph commented Mar 23, 2022

Should we overwrite backups when there are changes or should we create new ones with timestamps to identify them ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants