fix: get npm version registry not work && add get npm info cache (#164)

* fix: get npm version registry not work && add get npm info cache

* export getNpmPackageInfo function

* fix: lint error

Author: caohuilin

.changeset/dull-lies-sneeze.md

@@ -0,0 +1,7 @@
+---
+"@modern-js/codesmith": patch
+---
+
+fix: get npm version registry not work && add get npm info cache
+
+fix: 修复获取 npm 版本 registry 不生效 && 新增获取 npm 信息缓存

packages/core/src/utils/getNpmPackageInfo.ts

@@ -0,0 +1,42 @@
+import { NPM_API_TIMEOUT } from '@/constants';
+import axios from 'axios';
+import { getNpmRegistry } from './getNpmRegistry';
+import { timeoutPromise } from './timeoutPromise';
+
+interface Options {
+  registryUrl?: string;
+}
+
+interface PackageInfo {
+  version: string;
+  dist: {
+    tarball: string;
+  };
+}
+
+const NpmPackageInfoCache = new Map<string, PackageInfo>();
+
+export async function getNpmPackageInfo(
+  pkgName: string,
+  pkgVersion: string,
+  options?: Options,
+): Promise<PackageInfo> {
+  const packageName = `${pkgName}/${pkgVersion}`;
+  const packageInfo = NpmPackageInfoCache.get(packageName);
+  if (packageInfo) {
+    return packageInfo;
+  }
+  const { registryUrl = await getNpmRegistry() } = options || {};
+
+  const url = `${registryUrl}/${pkgName}/${pkgVersion}`;
+
+  const response = await timeoutPromise(
+    axios.get(url),
+    NPM_API_TIMEOUT,
+    `Get npm package info of '${pkgName}'`,
+  );
+
+  NpmPackageInfoCache.set(packageName, response.data);
+
+  return response.data;
+}

packages/core/src/utils/getNpmRegistry.ts

@@ -0,0 +1,6 @@
+import { execa } from '@modern-js/codesmith-utils/execa';
+
+export async function getNpmRegistry() {
+  const { stdout } = await execa('npm', ['config', 'get', 'registry']);
+  return stdout.replace(/\/$/, '') || 'https://registry.npmjs.org';
+}

packages/core/src/utils/getNpmTarballUrl.ts

@@ -1,6 +1,4 @@
-import { NPM_API_TIMEOUT } from '@/constants';
-import axios from 'axios';
-import { timeoutPromise } from './timeoutPromise';
+import { getNpmPackageInfo } from './getNpmPackageInfo';
 
 interface Options {
   registryUrl?: string;
@@ -11,15 +9,7 @@ export async function getNpmTarballUrl(
   pkgVersion: string,
   options?: Options,
 ): Promise<string> {
-  const { registryUrl = 'https://registry.npmjs.org' } = options || {};
+  const packageInfo = await getNpmPackageInfo(pkgName, pkgVersion, options);
 
-  const url = `${registryUrl}/${pkgName}/${pkgVersion}`;
-
-  const response = await timeoutPromise(
-    axios.get(url),
-    NPM_API_TIMEOUT,
-    `Get npm tarball of '${pkgName}'`,
-  );
-
-  return response.data.dist.tarball;
+  return packageInfo.dist.tarball;
 }

packages/core/src/utils/getNpmVersion.ts

@@ -1,6 +1,4 @@
-import { NPM_API_TIMEOUT } from '@/constants';
-import axios from 'axios';
-import { timeoutPromise } from './timeoutPromise';
+import { getNpmPackageInfo } from './getNpmPackageInfo';
 
 /**
  * get package version
@@ -18,16 +16,8 @@ export async function getNpmVersion(
   packageName: string,
   options?: Options,
 ): Promise<string> {
-  const { version = 'latest', registryUrl = 'https://registry.npmjs.org' } =
-    options || {};
+  const { version = 'latest' } = options || {};
+  const packageInfo = await getNpmPackageInfo(packageName, version, options);
 
-  const url = `${registryUrl}/${packageName}/${version}`;
-
-  const response = await timeoutPromise(
-    axios.get(url),
-    NPM_API_TIMEOUT,
-    `Get npm version of '${packageName}'`,
-  );
-
-  return response.data.version;
+  return packageInfo.version;
 }

packages/core/src/utils/index.ts

@@ -5,3 +5,5 @@ export { timeoutPromise } from './timeoutPromise';
 export { downloadPackage, getGeneratorVersion } from './downloadPackage';
 export { getNpmVersion } from './getNpmVersion';
 export { getPackageInfo } from './getPackageInfo';
+export { getNpmRegistry } from './getNpmRegistry';
+export { getNpmPackageInfo } from './getNpmPackageInfo';