[Optimize]: RsdoctorRspackMultiplePlugin brief + writeDataJson has outputs messed up

[ItamarGronich]

Version

System:
    OS: macOS 14.7.6
    CPU: (10) arm64 Apple M2 Pro
    Memory: 44.19 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Browsers:
    Chrome: 138.0.7204.169
    Safari: 18.5
  npmPackages:
    @rsdoctor/rspack-plugin: ^1.1.10 => 1.1.10

Details

Warning

This bug is inconsistent between builds.
It may not reproduce on your first try, but it will eventually.

When running rsdoctor in multiplugin setup, with this config:

new RsdoctorRspackMultiplePlugin({
  name: config.target as "web" | "node",
  stage: index, // 0 | 1 | 2 ...
  mode: "brief",
  brief: {
    writeDataJson: true,
  },
});

Then the output for the two builds are messed up:

dist/
├── node/
│   └── .rsdoctor
│       ├── rsdoctor-report.html // <== This is the web builds report HTML
│       └── .slaves
│           └── node-3
│               ├── ... data files ...
│               ├── manifest.json // <== This is the node build's manifest.json
│               └── rsdoctor-report.html // <== This is the node builds report HTML!
└── web
    └── .rsdoctor
        ├── ... data files ...
        └── manifest.json // <== This is the web builds manifest.json

Expected Behavior

The dist/node and dist/web folders should both contain a rsdoctor-report.html file, and the manifest.json file and should be identical in both folders.

dist/
├── node/
│   └── .rsdoctor
│       ├── ... data files ...
│       ├── manifest.json // <== This is the "node" build's manifest.json
│       └── rsdoctor-report.html // <== This is the "node" builds report HTML
└── web
    └── .rsdoctor
        ├── ... data files ...
        ├── manifest.json // <== This is the "web" build's manifest.json
        └── rsdoctor-report.html // <== This is the "web" builds report HTML

Interesting notes

If you delete the name configuration from the plugin config but leave it on each config (checkout branch no-plugin-name to see), things do get better but not ideal.
result:

dist/
├── node/
│   └── .rsdoctor
│       └── .slaves
│           └── node
│               ├── ... data files ...
│               ├── manifest.json // <== This is the "node" build's manifest.json
│               └── rsdoctor-report.html // <== This is the "node" builds report HTML
└── web
    └── .rsdoctor
        ├── ... data files ...
        ├── manifest.json // <== This is the "web" build's manifest.json
        └── rsdoctor-report.html // <== This is the "web" builds report HTML

Reproduce link

https://github.com/ItamarGronich/rsdoctor-mutli-json-repro

Reproduce Steps

Steps to Reproduce

1. Clone the repository.
2. Run pnpm i
3. Run pnpm build
4. inspect the two dist folders:
   • dist/node
   • dist/web

[yifancong]

Using RsdoctorRspackPlugin is acceptable.

[ItamarGronich]

Using RsdoctorRspackPlugin is acceptable.

@easy1090
But the multi plugin shares the sdk and some work no?
And also, in non brief mode it shows a nice select dropdown enabling one dashboard to view all compilations.

[ItamarGronich]

This would also be fine

dist/
├── .rsdoctor/
|         ├── node/
│         |   ├── ... data files ...
│         |   ├── manifest.json // <== This is the "node" build's manifest.json
│         |   └── rsdoctor-report.html // <== This is the "node" builds report HTML
|         └── web/
│             ├── ... data files ...
│             ├── manifest.json // <== This is the "web" build's manifest.json
│             └── rsdoctor-report.html // <== This is the "web" builds report HTML
├── node/
|   └── ... build files ...
└── web
    └── ... build files ...

[yifancong]

@ItamarGronich Yes, the multi plugin can merge reports from multiple compilations into a single webview. I understand your requirement, this will be supported after a future refactor.

[ItamarGronich]

@yifancong I've added a reproduction just wasn't clearly formatted - now changed.

[yifancong]

👌 This requires a certain amount of reconstruction code, so it may not take a long time. It is recommended to replace it with RsdoctorRspackPlugin temporarily. |