Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the throws in aria-utils #102

Open
cookiecrook opened this issue Jan 26, 2024 · 1 comment
Open

Refactor the throws in aria-utils #102

cookiecrook opened this issue Jan 26, 2024 · 1 comment

Comments

@cookiecrook
Copy link
Collaborator

[the throw messages in aria-utils] only a help for authors while writing the test, and a classname typo would still result in a silent failure unless all of them had the same typo, so @annevk pointed out they have limited utility.

Originally posted by @cookiecrook in web-platform-tests/wpt#43740 (comment)

Perhaps there is a better way to approach this.

@cookiecrook cookiecrook changed the title I may be misunderstanding your point, but I'm coming around to leaving it out... This is only a help for authors while writing the test, and a classname typo would still result in a silent failure unless _all_ of them had the same typo, so I can see your point about limited utility. Refactor the throws in aria-utils Jan 26, 2024
@cookiecrook
Copy link
Collaborator Author

Actually in discussing with @rahimabdi today, any necessary changes will probably just be worked into @jugglinmike's PR for

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant