Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test change proposal: mark light-dark() and system colors as not computationally independent #903

Open
zrhoffman opened this issue Nov 11, 2024 · 0 comments
Labels
test-change-proposal Proposal to add or remove tests for an interop area

Comments

@zrhoffman
Copy link

zrhoffman commented Nov 11, 2024

Test List

The additions are in https://phabricator.services.mozilla.com/D226869.

Rationale

Both light-dark() and system colors are color-scheme dependent.

From the spec:

A property value is computationally independent if it can be converted into a computed value using only the value of the property on the element, and "global" information that cannot be changed by CSS.

By that definition, colors that are color-scheme dependent are not computationally independent, so they should not be allowed as custom property initial values. I have added test coverage for this in the linked patch.

@dshin-moz has filed bugs for this:

cc @nt1m, @andruud, @emilio

@zrhoffman zrhoffman added the test-change-proposal Proposal to add or remove tests for an interop area label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Development

No branches or pull requests

1 participant