Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSSWG resolved to clarify Flexbox Intrinsic Main Size algorithm #94

Closed
jensimmons opened this issue Jul 7, 2022 · 8 comments
Closed
Labels
test-change-proposal Proposal to add or remove tests for an interop area

Comments

@jensimmons
Copy link
Contributor

Details in this issue: w3c/csswg-drafts#7189

This will require tests to be updated / will affect scores. Sounds like @davidsgrogan is working on such test updates.

Just an FYI to help make sure follow-up happens.

@gsnedders gsnedders added the test-change-proposal Proposal to add or remove tests for an interop area label Sep 16, 2022
@gsnedders
Copy link
Member

I think this was web-platform-tests/wpt#35214?

@davidsgrogan
Copy link
Member

There are still some flexbox tests that have not been updated to match the specified intrinsic size algorithm.

@foolip
Copy link
Member

foolip commented Sep 20, 2022

@davidsgrogan do you know if those could be enumerated to create a burndown list? Or would that amount to reviewing all tests?

@foolip
Copy link
Member

foolip commented Feb 7, 2023

@bfgeek do you know if the spec changes here are fully reflected in the test suite?

@jensimmons are you aware of test changes still needed?

Yes, I'm wondering if we can close this issue :)

@jensimmons
Copy link
Contributor Author

I don't have any knowledge of the state of the tests.

@bfgeek
Copy link

bfgeek commented Feb 7, 2023

@foolip
Copy link
Member

foolip commented Mar 16, 2023

@bfgeek if there's a significant change to the tests coming up, can you make sure to file a new test change proposal in this repo, so it doesn't catch anyone working on Interop 2023 by surprise? We're closing this issue because there isn't anything for the interop team to do here now.

@foolip foolip closed this as completed Mar 16, 2023
@foolip
Copy link
Member

foolip commented Mar 16, 2023

(Per discussion in #301.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Development

No branches or pull requests

5 participants