Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum viewport size #188

Open
annevk opened this issue Mar 19, 2024 · 3 comments
Open

Minimum viewport size #188

annevk opened this issue Mar 19, 2024 · 3 comments

Comments

@annevk
Copy link
Member

annevk commented Mar 19, 2024

As discussed in web-platform-tests/wpt#45161 and prior to that in web-platform-tests/wpt#7644 and elsewhere there's minimum viewport size assumptions. As @jgraham points out we should probably put those in wptrunner.

@gsnedders
Copy link
Member

For reftests we expect exactly an 800x600 viewport, and I think we should probably just make that assumption for all tests.

@jgraham
Copy link
Contributor

jgraham commented Mar 19, 2024

Requiring an exact size means that non-reftests have the same problem on mobile that reftests have i.e. you either can't run them or have to run in some very nonstandard viewport.

I tend to think that for testharness tests we want to discourage writing tests that depend on the exact dimensions, but it probably does make sense to ensure some minimum dimensions so that tests have something reasonable to rely on.

@gsnedders
Copy link
Member

The rightmost Firefox run here and the rightmost Chrome run here are done with 800x600px viewports for testharness and crashtest tests, which shows up a decent number of differences (oh no).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants