Remove hardcoded https scheme and use appropriate scheme depending on environment. #2941

DanielRyanSmith · 2022-08-19T21:04:22Z

Background

There are places in the code where the url scheme is hardcoded to https. As a result, when a developer has all of the micro services up locally, the webapp micro service cannot call the search cache service because the scheme is hardcoded.

Definition of Done

Find all places of hardcoded with https and have it use the appropriate scheme depending on where it is deployed (locally or google cloud)
The microservices work together not only when deployed but locally.

Examples (not exhaustive)

Example 1:

wpt.fyi/api/query/search.go

Lines 165 to 166 in cee243f

    
           // TODO(Issue #2941): This will not work when hostname is localhost (http scheme needed). 
        
           fwdURL, err := url.Parse(fmt.Sprintf("https://%s/api/search/cache", hostname))

Example 2:

wpt.fyi/shared/fetch_runs.go

Lines 25 to 26 in 9c7b693

    
           url := "https://" + wptdHost + "/api/runs" 
        
           url += "?" + filter.OrDefault().ToQuery().Encode()

Example 3:

wpt.fyi/api/checks/update.go

Line 234 in 9c7b693

HostURL: fmt.Sprintf("https://%s/", host),

Example 4:

wpt.fyi/shared/appengine.go

Line 329 in 9c7b693

    
           result, _ := url.Parse(fmt.Sprintf("https://%s%s", a.GetVersionedHostname(), "/api/results/upload"))

Example 5:

wpt.fyi/shared/appengine.go

Line 359 in 9c7b693

detailsURL, _ := url.Parse(fmt.Sprintf("https://%s%s", host, path))

Example 6:

wpt.fyi/shared/run_diff.go

Line 51 in 9c7b693

    
           detailsURL, _ := url.Parse(fmt.Sprintf("https://%s/results/", d.aeAPI.GetHostname()))

Example 7:

wpt.fyi/shared/run_diff.go

Line 383 in 9c7b693

    
           diffURL, _ := url.Parse(fmt.Sprintf("https://%s/api/search", d.aeAPI.GetVersionedHostname()))

Example 8:

wpt.fyi/webapp/admin_handler.go

Line 57 in 9c7b693

    
           CallbackURL: fmt.Sprintf("https://%s/api/results/create", a.GetVersionedHostname()),

Example 9:

wpt.fyi/webapp/login.go

Line 259 in 9c7b693

callback := url.URL{Scheme: "https", Host: r.Host, Path: "oauth"}

The text was updated successfully, but these errors were encountered:

DanielRyanSmith mentioned this issue Aug 19, 2022

Use searchcache results if summary file is old format #2920

Merged

jcscottiii added the hacktoberfest label Sep 30, 2022

jcscottiii changed the title ~~Search cache testing will not work when hostname is localhost (http scheme needed)~~ Remove hardcoded https scheme and use appropriate scheme depending on environment. Sep 30, 2022

jcscottiii self-assigned this Nov 22, 2022

jcscottiii linked a pull request Nov 22, 2022 that will close this issue

Start of the work to have a flexible scheme #3037

Draft

LeonardYam mentioned this issue Apr 6, 2023

Fix case-sensitive path matching for the search box #3249

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove hardcoded https scheme and use appropriate scheme depending on environment. #2941

Remove hardcoded https scheme and use appropriate scheme depending on environment. #2941

DanielRyanSmith commented Aug 19, 2022 •

edited by jcscottiii

Loading

Remove hardcoded https scheme and use appropriate scheme depending on environment. #2941

Remove hardcoded https scheme and use appropriate scheme depending on environment. #2941

Comments

DanielRyanSmith commented Aug 19, 2022 • edited by jcscottiii Loading

Background

Definition of Done

Examples (not exhaustive)

DanielRyanSmith commented Aug 19, 2022 •

edited by jcscottiii

Loading