Skip to content
This repository has been archived by the owner on Dec 14, 2022. It is now read-only.

Move unixfs chunking logic to ipfs-car, carbites, and w3up-client #107

Open
olizilla opened this issue Oct 4, 2022 · 1 comment
Open
Assignees
Labels
fdbk/users Feedback from cli users kind/enhancement A net-new feature or improvement to an existing feature PKey A key task or deliverable

Comments

@olizilla
Copy link
Contributor

olizilla commented Oct 4, 2022

The code for creating a CAR for an upload should be in a re-usable library that folks can build on in there own apps.

The existing web3.storage client library uses ipfs-car and carbites to handle car creation and car splitting, so any improvements that are needed in those libs to make it possible for w3up-client to defer most of the work to them should be prioritised.

TL:DR

  • at least move all the CAR creation logic to w3up-client where it can be imported and built on in users apps. No one wants to depend on a cli module from an app.
  • better move the generic parts to ipfs-car for car creation and carbites for car splitting, then consume those functions from w3up-client.
@olizilla olizilla added kind/bug A bug in existing code (including security flaws) fdbk/users Feedback from cli users labels Oct 4, 2022
@olizilla olizilla changed the title Move unixfs chunking logic to ipfs-car, carbites, and w3up-client` Move unixfs chunking logic to ipfs-car, carbites, and w3up-client Oct 4, 2022
@JeffLowe
Copy link
Contributor

JeffLowe commented Oct 4, 2022

Possible duplicate of web3-storage/w3up-client#27 I left a note there to confirm it is a duplicate, and if yes then close that one out in favor of this one.

@JeffLowe JeffLowe added kind/enhancement A net-new feature or improvement to an existing feature and removed kind/bug A bug in existing code (including security flaws) labels Oct 4, 2022
@JeffLowe JeffLowe added this to the Week 22.10.10 - 22.10.16 milestone Oct 7, 2022
@JeffLowe JeffLowe added PKey A key task or deliverable and removed epic labels Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fdbk/users Feedback from cli users kind/enhancement A net-new feature or improvement to an existing feature PKey A key task or deliverable
Projects
None yet
Development

No branches or pull requests

3 participants