Use the correct form of sha1.Sum (#111)

mcsaucy · web-flow · commit 1d499ab5c029 · 2025-05-01T19:13:54.000+02:00
sha1.New().Sum(x) appends a hash of nothing to x. See https://go.dev/play/p/h6pGFHEzbfA
diff --git a/metrics/servicediscovery.go b/metrics/servicediscovery.go
@@ -41,7 +41,7 @@ func (sd *AzureServiceDiscovery) fetchResourceList(subscriptionId, filter string
 	// nolint:gosec
 	cacheKey := fmt.Sprintf(
 		"%x",
-		string(sha1.New().Sum([]byte(fmt.Sprintf("%v:%v", subscriptionId, filter)))),
+		sha1.Sum([]byte(fmt.Sprintf("%v:%v", subscriptionId, filter))),
 	)
 
 	// try to fetch info from cache

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ func (sd *AzureServiceDiscovery) fetchResourceList(subscriptionId, filter string`
`41`	`41`	`// nolint:gosec`
`42`	`42`	`cacheKey := fmt.Sprintf(`
`43`	`43`	`"%x",`
`44`		`- string(sha1.New().Sum([]byte(fmt.Sprintf("%v:%v", subscriptionId, filter)))),`
	`44`	`+ sha1.Sum([]byte(fmt.Sprintf("%v:%v", subscriptionId, filter))),`
`45`	`45`	`)`
`46`	`46`
`47`	`47`	`// try to fetch info from cache`