Fix to remove the ability to upgrade the theme from the UI

Author: iliaross

authentic-init.pl

@@ -9,6 +9,7 @@
      @theme_bundle_js,
      %module_text_full,
      %theme_config,
+     $theme_info,
      %theme_text,
      %theme_temp_data,
      $get_user_level,
@@ -802,6 +803,8 @@ sub init_vars
                          settings(get_taconfig_file()),
                          settings(get_tgconfig_file(), "settings_"),
                          settings(get_tuconfig_file(), "settings_"));
+    our $theme_info = get_current_theme_info_cached($current_theme);
+
     our $http_x_url =
       (get_env('http_x_pjax_url') || get_env('http_x_progressive_url'));
 
@@ -1614,11 +1617,9 @@ sub theme_version
     my $tversions = getvar('tversion_cached');
 
     if (!$tversions || $nocache) {
-        my %tinfo    = get_theme_info($current_theme);
-        my $version  = $tinfo{'version'};
-        my $mversion = $tinfo{'mversion'};
-        my $bversion = $tinfo{'bversion'};
-
+        my $version           = $theme_info->{'version'};
+        my $mversion          = $theme_info->{'mversion'};
+        my $bversion          = $theme_info->{'bversion'};
         my $is_alpha          = string_contains($version, 'alpha');
         my $is_beta           = string_contains($version, 'beta');
         my $is_rc             = string_contains($version, 'RC');
@@ -1720,6 +1721,8 @@ sub header_html_data
       foreign_available("xterm") .
       '" data-shell="' .
       foreign_available("shell") .
+      '" data-upgrade="' .
+      ($theme_config{'settings_upgrade_allowed'} eq 'true' ? '1' : '0') .
       '" data-webmin="' .
       foreign_available("webmin") .
       '" data-usermin="' .

authentic-lib.pl

@@ -20,7 +20,7 @@
     $theme_root_directory,
     $current_theme, $root_directory, $config_directory, $var_directory,
 
-    %theme_text,     %module_text_full, %theme_config, $get_user_level, $theme_webprefix, $http_x_url,
+    %theme_text,     %module_text_full, %theme_config, $theme_info, $get_user_level, $theme_webprefix, $http_x_url,
     $has_virtualmin, $has_cloudmin,
     $has_usermin,    $has_usermin_version, $has_usermin_root_dir, $has_usermin_conf_dir, $has_usermin_var_dir);
 
@@ -780,7 +780,7 @@ sub get_sysinfo_vars
         }
 
         # Fetch theme version
-        if (&webmin_user_is_admin()) {
+        if (&webmin_user_is_admin() && $theme_config{'settings_upgrade_allowed'} eq 'true') {
 
             # Theme version/update
             my $authentic_remote_data                = theme_remote_version(1);
@@ -1561,7 +1561,7 @@ sub theme_update_incompatible
 
 sub theme_remote_version
 {
-
+    return if ($theme_config{'settings_upgrade_allowed'} ne 'true');
     my ($data, $force_stable_check, $force_beta_check, $nocache) = @_;
 
     my $remote_version = 0;

tconfig-lib.pl

@@ -11,14 +11,16 @@
      $current_theme,
      $theme_webprefix,
      %theme_config,
+     $theme_info,
      %theme_text,
      $has_usermin,
      $has_usermin_root_dir,
      $get_user_level);
 
 sub theme_settings_raw
 {
-    return (
+    # Available settings
+    my @theme_settings_raw = (
         [
          {  'id'    => 's1',
             'title' => &theme_text('settings_global_general_options_title'),
@@ -151,14 +153,21 @@ sub theme_settings_raw
                        'settings_hotkey_custom_8_user',
                        'settings_hotkey_custom_9_user',
             ] }
-        ],
-
+        ]);
+    # Add upgrade settings if available
+    if ($theme_config{'settings_upgrade_allowed'} eq 'true') {
+        push(@theme_settings_raw,
         [
          {  'id'    => 's8',
             'title' => &theme_text('settings_right_soft_updates_page_options'),
-            'data'  =>
-              ['settings_sysinfo_theme_updates', 'settings_sysinfo_theme_updates_for_usermin', 'settings_cache_interval'] }
+            'data'  => [
+                        'settings_sysinfo_theme_updates', 
+                        'settings_sysinfo_theme_updates_for_usermin',
+                        'settings_cache_interval'
+            ] }
         ]);
+    }
+    return @theme_settings_raw;
 }
 
 sub theme_settings_filter

unauthenticated/js/bundle.min.js

@@ -97,6 +97,7 @@ var
     settings_hotkey_custom_9_user = '',
 
     // Theme updates options defaults
+    settings_upgrade_allowed = false,
     settings_sysinfo_theme_updates = false,
     settings_cache_interval = 86400,
     settings_sysinfo_theme_updates_for_usermin = true,

unauthenticated/js/bundle.min.js.gz

@@ -6,7 +6,7 @@
 use strict;
 
 our (%in, %gconfig, $root_directory, $remote_user, $get_user_level,
-     %theme_config, %theme_text, $current_theme, $has_usermin);
+     %theme_config, $theme_info, %theme_text, $current_theme, $has_usermin);
 
 sub xhr
 {
@@ -487,7 +487,8 @@ sub xhr
             print convert_to_json(\@current_versions);
         } elsif ($in{'xhr-theme_clear_cache'} eq '1') {
             clear_theme_cache(&webmin_user_is_admin(), $in{'xhr-theme_clear_cache_full'});
-        } elsif ($in{'xhr-update'} eq '1' && &webmin_user_is_admin()) {
+        } elsif ($in{'xhr-update'} eq '1' && &webmin_user_is_admin() &&
+                 $theme_config{'settings_upgrade_allowed'} eq 'true') {
             my @update_rs;
             my $version_type            = ($in{'xhr-update-type'} eq '-beta' ? '-beta' : '-release');
             my $update_force            = $in{'xhr-update-force'};