Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status mail wrong encoding #67

Open
DrCarsonBeckett opened this issue Nov 22, 2020 · 12 comments
Open

Status mail wrong encoding #67

DrCarsonBeckett opened this issue Nov 22, 2020 · 12 comments

Comments

@DrCarsonBeckett
Copy link

DrCarsonBeckett commented Nov 22, 2020

We're about to release Webmin 1.962 and Usermin 1.811, which are going to include these patches. Within few days, as you install updates, please come back to us sharing how it works for you.

Originally posted by @iliarostovtsev in webmin/webmin#1272 (comment)

I need to open another ticket for that too.
I received a few mails and the issue is still there.
It happens in different browsers (IE, Edge, Firefox, iOS Safari and iOS Firefox) as well on other PCs. It happens in Outlook and Thunderbird as well, the only mail app which displays it correctly for me is the iOS default Mail app.

System:
Debian 10
Webmin-Version | 1.962
Usermin-Version | 1.812
Virtualmin Version | 6.14
Authentic theme version | 19.62

Edit: I opened the issue first in the webmin area and closed it (#1332), sorry.

@iliajie
Copy link
Collaborator

iliajie commented Nov 22, 2020

Hi,

How this issue is different from #66?

It happens in different browsers (IE, Edge, Firefox, iOS Safari and iOS Firefox) as well on other PCs. It happens in Outlook and Thunderbird as well

What happens?

I opened the issue first in the webmin area and closed it (#1332), sorry.

No problem, thanks!

@DrCarsonBeckett
Copy link
Author

DrCarsonBeckett commented Nov 22, 2020

I am not sure if its related to that or if its something else. This is about the encoding in the mails and not on the website.

What happens?
That the characters in the mail are getting displayed wrong.

This is what gets shown in the mails:

Backup ist komplett. Die Gesamtgröße beträgt

Which should be displayed as:

Backup ist komplett. Die Gesamtgröße beträgt

@iliajie
Copy link
Collaborator

iliajie commented Nov 22, 2020

I am not sure if its related to that or if its something else. This is about the encoding in the mails and not on the website.

Considering it's generated by Virtualmin, it must be our bug, right @jcameron 🙂

@jcameron
Copy link
Collaborator

Looks like our bug. Can you post the email here as an attachment, with all headers?

@DrCarsonBeckett
Copy link
Author

I prefer not to do that due to the fact that data would be public then and I prefer that some of them are not.
I can send them however via pm if that's somewhat possible.

@iliajie
Copy link
Collaborator

iliajie commented Nov 23, 2020

Yes, you can send it to me using my website's form. We will deal with it.

@DrCarsonBeckett
Copy link
Author

I just sent it.

webmin pushed a commit to webmin/webmin that referenced this issue Nov 30, 2020
@iliajie
Copy link
Collaborator

iliajie commented Nov 30, 2020

This webmin/webmin@1f9e479 should fix this. Could you test it please?

@DrCarsonBeckett
Copy link
Author

Tested it, its still the same.
From what I read in the patch / note in the commit, its no wonder since the message(-content) itself is displayed wrong and not only the subject. Or did I misunderstood that?

@DrCarsonBeckett
Copy link
Author

The odd thing is, that only the backup report mail seems to be wrong. All other emails are encoded correctly (everywhere).
Even usermin got issues displaying it correctly, so its not only related to Outlook.

@jcameron
Copy link
Collaborator

jcameron commented Dec 6, 2020

I looked into this, and it turns out that the code for sending backup status emails in Virtualmin is different and needed to be fixed separately.

@DrCarsonBeckett
Copy link
Author

DrCarsonBeckett commented Dec 6, 2020

From what I talked with @iliarostovtsev (thanks again for the great support), he said the same. If I understood correctly, you guys added encoding to it. And he said, it should be fixed with the latest virtualmin package (6.14). So far, from the tests we did, it looks good ... at least for me.
The last status mail I recieved was also "bug" free on all apps and devices. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants