-
-
Notifications
You must be signed in to change notification settings - Fork 22
Open
Description
When loading a JSON file pointing to an archive (one served by browsertrix-cloud), I get the error message
Sorry, this URL could not be loaded because the size of the file is not accessible.
Make sure this is a valid URL and you have access to this file.
It appears that for JSON files the sourceLoader
does not return a length
in this case
Lines 562 to 570 in d7e0021
if (!sourceLoader.length) { | |
progressUpdate(0, `\ | |
Sorry, this URL could not be loaded because the size of the file is not accessible. | |
Make sure this is a valid URL and you have access to this file.`); | |
if (abort) { | |
abort.abort(); | |
} | |
return false; | |
} |
And indeed, when disabling this check, the archive is loaded correctly.
Does it make sense to replace this conditional by the following (which works for me)?
if (sourceLoader.canLoadOnDemand && !sourceLoader.length) {
Metadata
Metadata
Assignees
Labels
No labels