Skip to content
This repository was archived by the owner on May 13, 2024. It is now read-only.

Commit 9878d9a

Browse files
committed
Address comments + other tidying up
1 parent 78cfa95 commit 9878d9a

File tree

4 files changed

+17
-6
lines changed

4 files changed

+17
-6
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
browsers/
2+
browsers-tmp
23
firefox-*.tar.bz2
34
.DS_Store
45
node_modules/

test/run-tests

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,12 @@
1-
#!/bin/sh
21
#
3-
# Run testling with a default set of parameters
2+
# Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
43
#
4+
# Use of this source code is governed by a BSD-style license
5+
# that can be found in the LICENSE file in the root of the source
6+
# tree.
7+
#!/bin/sh
8+
9+
# Run testling with a default set of parameters
510
BINDIR=./browsers/bin
611
export BROWSER=${BROWSER-chrome}
712
export BVER=${BVER-stable}

test/run-tests.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* that can be found in the LICENSE file in the root of the source
66
* tree.
77
*/
8-
/* jshint node: true */
8+
/* eslint-env node */
99

1010
'use strict';
1111
var test = require('tape');

test/test.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* that can be found in the LICENSE file in the root of the source
66
* tree.
77
*/
8-
/* jshint node: true */
8+
/* eslint-env node */
99

1010
'use strict';
1111

@@ -32,18 +32,23 @@ test('Check Selenium lib buildDriver method', function(t) {
3232
});
3333

3434
test('Check Selenium lib getStats method', function(t) {
35+
if (process.env.BROWSER === 'firefox') {
36+
t.skip('getStats not supported on Firefox.');
37+
t.end();
38+
return;
39+
}
3540
var driver = require('../main.js').seleniumLib.buildDriver();
3641
var getStats = require('../main.js').seleniumLib.getStats;
3742

3843
driver.get('file://' + process.cwd() + '/test/testpage.html')
3944
.then(function() {
4045
t.plan(3);
4146
t.pass('Page loaded');
42-
return driver.executeScript('window.pc1 = new RTCPeerConnection;' +
47+
return driver.executeScript('window.pc1 = new RTCPeerConnection();' +
4348
'return window.pc1;');
4449
})
4550
.then(function(peerConnection) {
46-
if (typeof peerConnection === 'object') {
51+
if (typeof peerConnection.remoteDescription === 'object') {
4752
t.pass('PeerConnection created, calling on getStats.')
4853
return getStats(driver, 'pc1');
4954
}

0 commit comments

Comments
 (0)