Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-s / --select flag is broken #222

Closed
noahvogt opened this issue Jan 22, 2022 · 4 comments · Fixed by #304
Closed

-s / --select flag is broken #222

noahvogt opened this issue Jan 22, 2022 · 4 comments · Fixed by #304
Labels

Comments

@noahvogt
Copy link

What version of this package are you using?
according to webtorrent --version it is 4.0.2 (1.6.0)

What operating system, Node.js, and npm version?

  • OS: Linux
  • according to node --version it is v16.11.1
  • according to npm --version it is 8.1.3

What happened?
When executing webtorrent [magnet link] -s 13 I tried to select and download the file corresponding to index 13. But instead, this error came up after showing verifying existing torrent data... and before the download started. The problem is, whenever I enter a index higher than 10 to the -s / --select flag, webtorrent instead downloads the file corresponing to index number 1.

node:9799) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 ready listeners
added to [Torrent]. Use emitter.setMaxListeners() to increase limit
(Use `node --trace-warnings ...` to show where the warning was created)

What did you expect to happen?
I didn't expect that webtorrent start downloading file index 1 instead of file number 13 when i specified -s 13.

Are you willing to submit a pull request to fix this bug?
No, since I have zero experience with Node and as of now couldn't really be beneficial to this project in contributing code.

@github-actions
Copy link

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@github-actions github-actions bot added the stale label Mar 23, 2022
@noahvogt
Copy link
Author

Yes, it is still relevant, as this issue has not yet been resolved. And no, I cannot really help as I don't know anything about the codebase of this project.

@alxhotel alxhotel added bug and removed stale labels Mar 23, 2022
@ghost
Copy link

ghost commented Oct 11, 2022

Actually, the select function itself is pretty useless as of now. As per #152, #250, etc. If you use this function & stream media for an extensive period, webtorrent will literally download everything in the background instead of selected ones.

@glottisfaun0000
Copy link

it would be cool if this was fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants