Fix/fetch json handles 404 (#2)

* fix: handle 404 when loading json

* release: v0.3.1

Author: halimath

package.json

@@ -1,6 +1,6 @@
 {
     "name": "@weccoframework/i18n",
-    "version": "0.3.0",
+    "version": "0.3.1",
     "description": "A simple, minimalistic i18n framework for use in browser",
     "license": "Apache-2.0",
     "repository": {

src/jsonsource.ts

@@ -48,7 +48,7 @@ export function fetchJsonByLocale(baseUrl: string, options?: RequestInit): JsonS
     }
 }
 
-function fetchText(url: string, options?: RequestInit): Promise<string> {
+function fetchText(url: string, options?: RequestInit): Promise<string | undefined> {
     return fetch(url, {
         body: options?.body,
         cache: options?.cache,
@@ -68,6 +68,11 @@ function fetchText(url: string, options?: RequestInit): Promise<string> {
             if (response.status < 300) {
                 return response.text()
             }
+
+            if (response.status === 404) {
+                return Promise.resolve(undefined)
+            }
+            
             throw `Got unexpected status code when loading '${url}': ${response.status} (${response.statusText})`
         })
 }

test/jsonsource.test.ts

@@ -69,24 +69,48 @@ describe("fetchJsonByLocale", () => {
     let url: string
     let requestInit: RequestInit
 
-    before(() => {
-        global.fetch = function (u: string, i: RequestInit): Promise<Response> {
-            url = u
-            requestInit = i
-
-            return Promise.resolve(new ResponseMock(200, `{"foo": "bar"}`))
-        }
-    
-        source = fetchJsonByLocale("/test/path", {
-            method: "POST",
+    describe("found", () => {        
+        before(() => {
+            global.fetch = function (u: string, i: RequestInit): Promise<Response> {
+                url = u
+                requestInit = i
+                
+                return Promise.resolve(new ResponseMock(200, `{"foo": "bar"}`))
+            }
+            
+            source = fetchJsonByLocale("/test/path", {
+                method: "POST",
+            })
+        })
+        
+        it("should load de.json", async () => {        
+            const json = await source(new Locale("de"))
+            expect(json).toBe(`{"foo": "bar"}`)
+            expect(url).toBe("/test/path/de.json")
+            expect(requestInit.method).toBe("POST")
         })
     })
 
-    it("should load de.json", async () => {        
-        const json = await source(new Locale("de"))
-        expect(json).toBe(`{"foo": "bar"}`)
-        expect(url).toBe("/test/path/de.json")
-        expect(requestInit.method).toBe("POST")
+    describe("not found", () => {        
+        before(() => {
+            global.fetch = function (u: string, i: RequestInit): Promise<Response> {
+                url = u
+                requestInit = i
+                
+                return Promise.resolve(new ResponseMock(404, ""))
+            }
+            
+            source = fetchJsonByLocale("/test/path", {
+                method: "POST",
+            })
+        })
+        
+        it("should load de.json", async () => {        
+            const json = await source(new Locale("de"))
+            expect(json).toBeUndefined()
+            expect(url).toBe("/test/path/de.json")
+            expect(requestInit.method).toBe("POST")
+        })
     })
 })