Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change: Puppet abstract class renamed to PuppetAbstractImpl #166

Closed
huan opened this issue Oct 22, 2021 · 1 comment
Closed

Breaking change: Puppet abstract class renamed to PuppetAbstractImpl #166

huan opened this issue Oct 22, 2021 · 1 comment
Labels
wontfix This will not be worked on

Comments

@huan
Copy link
Member

huan commented Oct 22, 2021

Before

  1. Puppet class is the abstract class

After

  1. Puppet class has been renamed to PuppetAbstractImpl
  2. Puppet is the interface of the Puppet
  3. Add PuppetConstructor type
@huan huan added breaking change enhancement New feature or request labels Oct 22, 2021
@huan huan mentioned this issue Oct 22, 2021
Open
13 tasks
huan added a commit that referenced this issue Oct 22, 2021
@huan
Breaking change: Puppet -> PuppetAbstractImpl (#166)
8a305ef
@huan huan added wontfix This will not be worked on and removed enhancement New feature or request breaking change labels Oct 22, 2021
huan added a commit that referenced this issue Oct 22, 2021
@huan
restore Puppet abstract class (#166)
0739089
@huan
Copy link
Member Author

huan commented Oct 22, 2021

After thinking it more, this will not be implemented anymore and is canceled.

@huan huan closed this as completed Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@huan