Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How can we get the state of the puppet with new API? #177

Closed
hcfw007 opened this issue Jan 5, 2022 · 5 comments
Closed

How can we get the state of the puppet with new API? #177

hcfw007 opened this issue Jan 5, 2022 · 5 comments
Labels
question Further information is requested

Comments

@hcfw007
Copy link
Member

hcfw007 commented Jan 5, 2022

Since this.state.on() or this.state.off() no longer works?
@huan
Copy link
Member

huan commented Jan 5, 2022 •
edited
Loading

They have been renamed. Use active / inactive instead

@hcfw007
Copy link
Member Author

hcfw007 commented Jan 5, 2022

Should puppet implementation manipulate these states?

@huan
Copy link
Member

huan commented Jan 5, 2022 •
edited
Loading

With v1.x , those states is manipulated by the puppet base class and should not be mutated by the child class any more.

You can refer to the puppets which have already upgraded to the v1.x to see the recommended usage.

@hcfw007
Copy link
Member Author

hcfw007 commented Jan 5, 2022

Cool, thanks for the explanation.

@hcfw007 hcfw007 closed this as completed Jan 5, 2022
@huan
Copy link
Member

huan commented Jan 5, 2022

You are welcome.

@huan huan added the question Further information is requested label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@huan @hcfw007