Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset event question #193

Closed
hcfw007 opened this issue May 11, 2022 · 5 comments
Closed

reset event question #193

hcfw007 opened this issue May 11, 2022 · 5 comments

Comments

@hcfw007
Copy link
Member

hcfw007 commented May 11, 2022

I'm trying to solve a problem relating to puppet not reseting correctly.
While I was reading the puppet code, i cannot find the part binding reset event to ServiceCtlMixin.reset(). Since puppet emitting reset event cannot trigger reset in my case, is there something I miss?

@huan
Copy link
Member

huan commented May 11, 2022

During the past we have changed the reset specification many times.

I’m not sure the current mechanism, so please help yourself to figure it out.

One tip is that I feel the RESET event should not pass across puppet layers, it should be a local and private event for the current puppet only.

@hcfw007
Copy link
Member Author

hcfw007 commented May 11, 2022

OK. Maybe this is a better question:
As a puppet implementation developer, should I pass the reset event up, or handle it at puppet implementation layer?

@huan
Copy link
Member

huan commented May 11, 2022

As a puppet implementation developer, should I pass the reset event up, or handle it at puppet implementation layer?

The RESET event is to reset the current system instead of resetting other system. so, for now, let's follow the below two rules:

  1. the RESET event should be a local/internal/private event for the current puppet
  2. a puppet can ignore the RESET event that does not emit by itself for now

Please feel free if you can find any use cases that need to break the above two rules.

@hcfw007
Copy link
Member Author

hcfw007 commented May 13, 2022

I understand the design now so issue can be closed.

@hcfw007 hcfw007 closed this as completed May 13, 2022
@huan
Copy link
Member

huan commented May 13, 2022

Glad to know that you understood the design, it would better to share what you have learned so that the future developers can learn from you.

And thank you very much for the house cleaning!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants