Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework WPS303: it should only be possible to write _ with 3 digits on the right #3120

Closed
sobolevn opened this issue Dec 11, 2024 · 4 comments · Fixed by #3128
Closed

Rework WPS303: it should only be possible to write _ with 3 digits on the right #3120

sobolevn opened this issue Dec 11, 2024 · 4 comments · Fixed by #3128
Labels
feature New feature or request good first issue Entrypoint to the project

Comments

@sobolevn
Copy link
Member

Right: 1_000 and 10_000 and 100_000 and 1_000_000
Wrong: 1_00 and 10_00
@sobolevn sobolevn added feature New feature or request good first issue Entrypoint to the project labels Dec 11, 2024
@EPoY74
Copy link

EPoY74 commented Dec 12, 2024

Hi!
I want to try solve this task.
Can I find out more?

@EPoY74
Copy link

EPoY74 commented Dec 12, 2024

Speaks Russian or English?

@sobolevn
Copy link
Member Author

Hi, sure!

Here's the main code that executes this check:

wemake-python-styleguide/wemake_python_styleguide/visitors/tokenize/primitives.py

Line 78 in 3d5fa48

if '_' in token.string:

Tests: https://github.com/wemake-services/wemake-python-styleguide/blob/master/tests/test_visitors/test_tokenize/test_primitives/test_numbers/test_underscored_numbers.py

PR is very welcome!

mmmylnikov added a commit to mmmylnikov/wemake-python-styleguide that referenced this issue Dec 12, 2024
@mmmylnikov
Reworked WPS303: possible to write _ with 3 digits on the right (wema…
cbf3012 
…ke-services#3120)
@mmmylnikov mmmylnikov mentioned this issue Dec 12, 2024
Merged
@sobolevn
Copy link
Member Author

please see tests: https://github.com/wemake-services/wemake-python-styleguide/blob/master/tests/test_visitors/test_tokenize/test_primitives/test_numbers/test_underscored_numbers.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request good first issue Entrypoint to the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WPS303: Allow underscore with 3 digits on the right mmmylnikov/wemake-python-styleguide
2 participants
@sobolevn @EPoY74