OAuth client parameters set via environment variables not supported?

[skomma]

Environment

Host

item	version
GROWI	3.6.8

How to reproduce? (再現手順)

• Start GROWI with the environment variable OAUTH_GOOGLE_CLIENT_ID OAUTH_GOOGLE_CLIENT_SECRET set.
  • These variables are described in GROWI Docs.
  • https://docs.growi.org/en/admin-guide/admin-cookbook/env-vars.html

What happens? (症状)

• GROWI says something like:

  [2020-02-28T09:19:01.347Z] ERROR: growi:crowi/72 on growi-app-545-5ff9d79667-vxkdk: OAuth2Strategy requires a clientID option
  TypeError: OAuth2Strategy requires a clientID option
      at Strategy.OAuth2Strategy (/opt/growi/node_modules/passport-oauth2/lib/strategy.js:82:34)
      at new Strategy (/opt/growi/node_modules/passport-google-oauth20/lib/strategy.js:52:18)
      at PassportService.setupGoogleStrategy (/opt/growi/src/server/service/passport.js:341:7)
      at Crowi.setupPassport (/opt/growi/src/server/crowi/index.js:315:26)
      at Crowi.init (/opt/growi/src/server/crowi/index.js:98:10)
      at processTicksAndRejections (internal/process/task_queues.js:97:5)
      at async Crowi.start (/opt/growi/src/server/crowi/index.js:369:3)
  

• The OAuth login feature seems to be disabled.
  • When accessing /passport/google, GROWI renders a Wiki page named /passport/google.

What is the expected result? (期待される動作)

• The OAuth login feature is enabled.

Note

• The implementation seems to be currently commented out.
  • https://github.com/weseek/growi/blob/master/src/server/service/config-loader.js#L55-L108