Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: AssertionConsumerServiceURL in SAML AuthnRequest is not changed when Site URL was changed #6773

Open
skomma opened this issue Oct 19, 2022 · 1 comment
Open

Improvement: AssertionConsumerServiceURL in SAML AuthnRequest is not changed when Site URL was changed #6773

skomma opened this issue Oct 19, 2022 · 1 comment
Labels
3️⃣ phase/confirmed good first issue type/improvement

Comments

@skomma
Copy link
Member

skomma commented Oct 19, 2022

Environment

Host

item version
OS
GROWI 5.1.3

How to reproduce? (再現手順)

  1. Start GROWI with Site URL https://aaa.com set and SAML auth enabled
  2. Go to the admin page, set https://bbb.com in the Site URL settings
  3. Logout
  4. Login with SAML

What happens? (症状)

  • AssertionConsumerServiceURL in SAML AuthnRequest is https://aaa.com/passport/saml/callback

What is the expected result? (期待される動作)

  • AssertionConsumerServiceURL in SAML AuthnRequest should be https://bbb.com/passport/saml/callback

Note

  • When SAML authentication is enabled and the Site URL is changed, it seems necessary to reload passport-saml.
@yuki-takei yuki-takei changed the title Bug: AssertionConsumerServiceURL in SAML AuthnRequest is not changed when Site URL was changed Improvement: AssertionConsumerServiceURL in SAML AuthnRequest is not changed when Site URL was changed Nov 7, 2022
@yuki-takei
Copy link
Member

yuki-takei commented Nov 7, 2022 •
edited
Loading

Not a bug.

We will add an alert to prompt the admin user to restart the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3️⃣ phase/confirmed good first issue type/improvement
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yuki-takei @skomma