Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify package setup by auto-adding everything needed in the app ready command #135

Closed
joshuadavidthomas opened this issue Feb 7, 2024 · 1 comment

Comments

@joshuadavidthomas
Copy link
Member

There are a bunch of steps one needs to take to use this package. Could be simplified by setting it all up in email_relay.apps.EmailRelayConfig.ready automatically, all someone would need to do is add email_relay to their INSTALLED_APPS list.

I've got a draft PR #23 that already does all this. Initially it's opt-in, so you would install the app and set DJANGO_EMAIL_RELAY["ENABLE_AUTO_SETUP"] = True. I could flip it to make it opt-out instead?

TBH, not totally sure on this one, may add too much magic and I'm not sure about the fragility of automatically adjusting settings outside of a project's settings.py. Though Carlton's https://github.com/carltongibson/django-template-partials package does this, so maybe I'm making a mountain out of a mole hill.

@joshuadavidthomas
Copy link
Member Author

Pending the changes proposed in #154, this may not be needed. Using that approach of each application managing their own email queue in its local database, so the need for a database router goes away and the setup becomes much simpler. And since the email router would be marked for deprecation, we wouldn't necessarily need this change.

Closing for now.

@joshuadavidthomas joshuadavidthomas closed this as not planned Won't fix, can't repro, duplicate, stale May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant