-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add Operator Fee for OP Stack Chains #3950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 3c95e35 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
129b947 to
9ad3509
Compare
d78cf00 to
b31cf2a
Compare
commit: |
|
@jxom any thoughts on this one? |
| const gasPriceOracleAddress = (() => { | ||
| if (gasPriceOracleAddress_) return gasPriceOracleAddress_ | ||
| if (chain) | ||
| if (chain?.contracts?.gasPriceOracle) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if (chain?.contracts?.gasPriceOracle) | |
| if (chain) |
| const gasPriceOracleAddress = (() => { | ||
| if (gasPriceOracleAddress_) return gasPriceOracleAddress_ | ||
| if (chain) | ||
| if (chain?.contracts?.gasPriceOracle) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if (chain?.contracts?.gasPriceOracle) | |
| if (chain) |
| const gasPriceOracleAddress = (() => { | ||
| if (gasPriceOracleAddress_) return gasPriceOracleAddress_ | ||
| if (chain) | ||
| if (chain?.contracts?.gasPriceOracle) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if (chain?.contracts?.gasPriceOracle) | |
| if (chain) |
jxom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add estimateOperatorFee to op-stack/decorators/publicL2.ts
| site/dist | ||
| .vercel | ||
| vocs.config.tsx.timestamp* | ||
| site/.cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| site/.cache |
Adding Operator Fee to the OP Stack actions. The Operator Fee is supported on OP Stack since the Isthmus Upgrade:
https://docs.optimism.io/stack/transactions/fees#operator-fee