Non-Exclusive LinuxMouse Offset Bugfix #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged feature and bug fix changes made to 2018 OIS 1.5.0 lib for GearCity 64-bit OSX Cocoa build into OIS's master + our Linux fixes. This update should also contain the Carbon non-exclusive mouse feature too.
|
Gah! Sorry, forgot to put the change I was submitting into its own branch. You can cherry pick out the code from the first comment if you want it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93
We only change the mouse positions if the mouse is grabbed and we have focus. Otherwise, we get an offset. If we don't have the mouse grabbed, or mouse focus is lost, just pipe in the Xmotion values directly.
The code could probably be merged into the clipping/warping if(grabMouse) conditional below. But I believe this is cleaner with less nesting.
Affected backends
Linux X11 Mouse.