-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EventTarget] Abort controller from a past subscription can remove events from future subscriptions #1346
Comments
rubennorte
added a commit
to rubennorte/react-native
that referenced
this issue
Jan 2, 2025
Summary: Changelog: [internal] Adds a regression test to make sure we implement the correct spec-compliant behavior for a possible bug in the Web spec: whatwg/dom#1346 Differential Revision: D67758702
rubennorte
added a commit
to rubennorte/react-native
that referenced
this issue
Jan 3, 2025
Summary: Changelog: [internal] Adds a regression test to make sure we implement the correct spec-compliant behavior for a possible bug in the Web spec: whatwg/dom#1346 Differential Revision: D67758702
rubennorte
added a commit
to rubennorte/react-native
that referenced
this issue
Jan 3, 2025
Summary: Changelog: [internal] Adds a regression test to make sure we implement the correct spec-compliant behavior for a possible bug in the Web spec: whatwg/dom#1346 Differential Revision: D67758702
rubennorte
added a commit
to rubennorte/react-native
that referenced
this issue
Jan 3, 2025
Summary: Changelog: [internal] Adds a regression test to make sure we implement the correct spec-compliant behavior for a possible bug in the Web spec: whatwg/dom#1346 Differential Revision: D67758702
rubennorte
added a commit
to rubennorte/react-native
that referenced
this issue
Jan 3, 2025
Summary: Changelog: [internal] Adds a regression test to make sure we implement the correct spec-compliant behavior for a possible bug in the Web spec: whatwg/dom#1346 Differential Revision: D67758702
rubennorte
added a commit
to rubennorte/react-native
that referenced
this issue
Jan 3, 2025
Summary: Changelog: [internal] Adds a regression test to make sure we implement the correct spec-compliant behavior for a possible bug in the Web spec: whatwg/dom#1346 Differential Revision: D67758702
rubennorte
added a commit
to rubennorte/react-native
that referenced
this issue
Jan 3, 2025
Summary: Changelog: [internal] Adds a regression test to make sure we implement the correct spec-compliant behavior for a possible bug in the Web spec: whatwg/dom#1346 Differential Revision: D67758702
rubennorte
added a commit
to rubennorte/react-native
that referenced
this issue
Jan 3, 2025
Summary: Changelog: [internal] Adds a regression test to make sure we implement the correct spec-compliant behavior for a possible bug in the Web spec: whatwg/dom#1346 Differential Revision: D67758702
rubennorte
added a commit
to rubennorte/react-native
that referenced
this issue
Jan 3, 2025
Summary: Changelog: [internal] Adds a regression test to make sure we implement the correct spec-compliant behavior for a possible bug in the Web spec: whatwg/dom#1346 Differential Revision: D67758702
rubennorte
added a commit
to rubennorte/react-native
that referenced
this issue
Jan 3, 2025
Summary: Changelog: [internal] Adds a regression test to make sure we implement the correct spec-compliant behavior for a possible bug in the Web spec: whatwg/dom#1346 Differential Revision: D67758702
rubennorte
added a commit
to rubennorte/react-native
that referenced
this issue
Jan 3, 2025
Summary: Changelog: [internal] Adds a regression test to make sure we implement the correct spec-compliant behavior for a possible bug in the Web spec: whatwg/dom#1346 Differential Revision: D67758702
rubennorte
added a commit
to rubennorte/react-native
that referenced
this issue
Jan 4, 2025
Summary: Changelog: [internal] Adds a regression test to make sure we implement the correct spec-compliant behavior for a possible bug in the Web spec: whatwg/dom#1346 Differential Revision: D67758702
rubennorte
added a commit
to rubennorte/react-native
that referenced
this issue
Jan 4, 2025
Summary: Changelog: [internal] Adds a regression test to make sure we implement the correct spec-compliant behavior for a possible bug in the Web spec: whatwg/dom#1346 Differential Revision: D67758702
rubennorte
added a commit
to rubennorte/react-native
that referenced
this issue
Jan 4, 2025
Summary: Changelog: [internal] Adds a regression test to make sure we implement the correct spec-compliant behavior for a possible bug in the Web spec: whatwg/dom#1346 Differential Revision: D67758702
rubennorte
added a commit
to rubennorte/react-native
that referenced
this issue
Jan 4, 2025
Summary: Changelog: [internal] Adds a regression test to make sure we implement the correct spec-compliant behavior for a possible bug in the Web spec: whatwg/dom#1346 Differential Revision: D67758702
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the issue with the DOM Standard?
The
addEventListener
method for theEventTarget
interface includes a step to add an abort step to remove the subscription: https://dom.spec.whatwg.org/#add-an-event-listener.In the
removeEventListener
method (in the same interface) there is no step to remove the previous abort step (https://dom.spec.whatwg.org/#remove-an-event-listener), which means that the abort controller will still try to remove the listener when aborted, even if the previous listener was removed.That can cause the abort controller to remove subscriptions where we abort controller itself was not used.
Example (which works according to the step and can be reproduced in browsers like Google Chrome):
This behavior does not match user expectations. Is it a bug in the specification, followed by implementers? Is this something that can be fixed at this point?
Thanks.
The text was updated successfully, but these errors were encountered: