-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add process model processing for the "Priority" header. #1757
base: main
Are you sure you want to change the base?
Conversation
Tests and implementation bugs coming soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks reasonable to me modulo nits. This means that service workers do not get to see the header ever unless it was set by a web developer. Do we have test coverage for that as well?
@@ -5654,6 +5654,12 @@ run these steps: | |||
default), and `<code>Accept-Charset</code>` is a waste of bytes. See | |||
<a>HTTP header layer division</a> for more details. | |||
|
|||
<li><p>If <var>httpRequest</var>'s <a for=request>header list</a> | |||
<a for="header list">does not contain</a> `<code>Priority</code>`, then user agents may |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and below should not be indented extra. Please align with <li><p>
.
<a for="header list">does not contain</a> `<code>Priority</code>`, then user agents may | ||
<a for="header list">append</a> a `<code>Priority</code>` <a>header</a> with an | ||
<a>implementation-defined</a> value derived from <var>httpRequest</var>'s | ||
<a for=request>internal priority</a> in accordance with RFC 9218. [[!RFC9218]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<cite>RFC 9218</cite>
Priority
request header #1718(See WHATWG Working Mode: Changes for more details.)
This adds the processing for the
Priority
HTTP header from HTTP Extensible Priorities (RFC 9218).The actual priority values are implementation-specific but this change makes it clear that an existing value should not be overwritten if the header is already present.
Fix #1718
Preview | Diff