Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub usernames are case-insensitive, I think? #34

Closed
domenic opened this issue Oct 8, 2018 · 2 comments
Closed

GitHub usernames are case-insensitive, I think? #34

domenic opened this issue Oct 8, 2018 · 2 comments

Comments

@domenic
Copy link
Member

domenic commented Oct 8, 2018 •
edited
Loading

whatwg/participant-data@815fbc6 added a user under the name "johanna-hub", but the official spelling of their username is "Johanna-hub", with an uppercase letter. So the PR whatwg/html#4068 was initially marked as not-OK.

I manually fixed participant-data as a one-off in this case. But, we should consider a better solution for the future. Either case-insensitive comparison, or canonicalization, or...

Related: #8.
domenic added a commit to whatwg/participant-data that referenced this issue Oct 8, 2018
@domenic
Verify Johanna Herman
6998305 
Also correct the casing of their username. See whatwg/participate.whatwg.org#34 for followup work to prevent this in the future.
@annevk
Copy link
Member

annevk commented Oct 9, 2018

@domenic test.

@annevk
Copy link
Member

annevk commented Oct 9, 2018

Hmm, so if I type @DOMENIC it stores that, but it shows a canonicalized version. Not sure what to make of that. Case-insensitive I guess.

domenic added a commit that referenced this issue Feb 27, 2019
@domenic
Perform case-insensitive username checking
d44b63e 
Fixes #34.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domenic @annevk