fix(model): skip CockroachDB advisory-lock specs via capability override (#2747)

* fix(model): skip CockroachDB advisory-lock specs via capability override

CockroachDBModel extends PostgreSQLModel, which reports
`$supportsAdvisoryLocks() = true` because Postgres has pg_advisory_lock.
CockroachDB does not, so its $acquireAdvisoryLock / $releaseAdvisoryLock
throw Wheels.AdvisoryLockNotSupported. Without a capability override the
four standalone advisory-lock specs in `lockingSpec.cfc` skipped past
their beforeEach guard and errored on every Cockroach-backed compat-
matrix run (Lucee 6, Lucee 7, BoxLang). Adding the override lets them
skip cleanly, matching the H2 / SQL Server treatment from #2665.

Fixes #2743

Signed-off-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>

* docs(model): rework CockroachDB $supportsAdvisoryLocks docblock per review

Reviewer A flagged that the existing wording led with "lets the test
suite skip standalone-lock paths instead of erroring" — framing the
override as a test workaround rather than a correctness fix. Reorder
to lead with the underlying behavior ($acquireAdvisoryLock /
$releaseAdvisoryLock throw Wheels.AdvisoryLockNotSupported), then
explain what consulting the flag enables, then cite the H2 / SQL
Server precedent from #2665.

No functional change.

Signed-off-by: Peter Amiri <peter@alurium.com>

---------

Signed-off-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Signed-off-by: Peter Amiri <peter@alurium.com>
Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Co-authored-by: Peter Amiri <peter@alurium.com>

Author: 3 people

vendor/wheels/databaseAdapters/CockroachDB/CockroachDBModel.cfc

@@ -39,12 +39,13 @@ component extends="wheels.databaseAdapters.PostgreSQL.PostgreSQLModel" output=fa
 	}
 
 	/**
-	 * CockroachDB intentionally omits the PostgreSQL advisory-lock primitives
-	 * (`pg_advisory_lock` / `pg_advisory_unlock`) — it surfaces them as no-op
-	 * stubs that error rather than honoring the contract. Override the
-	 * PostgreSQL adapter's `true` and report unsupported so `withAdvisoryLock`
-	 * callers (and the capability-aware lockingSpec `beforeEach`) skip
-	 * standalone-lock paths instead of erroring.
+	 * CockroachDB lacks a pg_advisory_lock equivalent — its
+	 * $acquireAdvisoryLock and $releaseAdvisoryLock both throw
+	 * Wheels.AdvisoryLockNotSupported. Overriding the parent PostgreSQL
+	 * adapter's `true` to `false` lets capability-aware callers
+	 * (`withAdvisoryLock`, the lockingSpec `beforeEach` guard) route around
+	 * the missing primitive instead of hitting the throw, matching the
+	 * H2 / SQL Server pattern from #2665.
 	 */
 	public boolean function $supportsAdvisoryLocks() {
 		return false;

vendor/wheels/tests/specs/database/CockroachDBUnitSpec.cfc

@@ -51,6 +51,13 @@ component extends="wheels.WheelsTest" {
 				});
 			});
 
+			describe("$supportsAdvisoryLocks", () => {
+
+				it("returns false (CockroachDB has no pg_advisory_lock equivalent)", () => {
+					expect(adapter.$supportsAdvisoryLocks()).toBeFalse();
+				});
+			});
+
 			describe("$identitySelect", () => {
 
 				it("returns lastId from result.generatedKey", () => {